<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4566#discussion_r496282536">core/src/main/java/bisq/core/trade/TradeManager.java</a>:</p>
<pre style='color:#555'>>          onTradesChanged();
 
-        getAddressEntriesForAvailableBalanceStream()
+        btcWalletService.getAddressEntriesForAvailableBalanceStream()
                 .filter(addressEntry -> addressEntry.getOfferId() != null)
                 .forEach(addressEntry -> {
                     log.warn("Swapping pending OFFER_FUNDING entries at startup. offerId={}", addressEntry.getOfferId());
                     btcWalletService.swapTradeEntryToAvailableEntry(addressEntry.getOfferId(), AddressEntry.Context.OFFER_FUNDING);
</pre>
<p>It was old code as well and I was wondering as well if its really needed. But did not want to risk to remove it or spend more time to think about the context. Not sure I can add a meaningful comment without starting to look more closely into it why it was added. I think it is a just a cleanup if address entries have not been swapped as intended in some error cases... We dont want that BitcoinJ creates too many addresses as it makes the wallet slower.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4566#discussion_r496282536">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUMFQBXWMBOSESL6OTSIEI7FANCNFSM4R3L7WRA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRP7I6UIANFITAKKPDSIEI7FA5CNFSM4R3L7WRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODWXDMAA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4566#discussion_r496282536",
"url": "https://github.com/bisq-network/bisq/pull/4566#discussion_r496282536",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>