<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4566#discussion_r496284190">core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerProcessesInputsForDepositTxRequest.java</a>:</p>
<pre style='color:#555'>>  
-            // Taker has to sign offerId (he cannot manipulate that - so we avoid to have a challenge protocol for passing the nonce we want to get signed)
+            // We set the taker fee only in the processModel yet not in the trade as the tx was only created but not
+            // published yet. Once it was published we move it to trade. The takerFeeTx should be sent in a later
+            // message bu that cannot be changed due backward compatibility issues. It is a left over from the
</pre>
<p>Will fix it..</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4566#discussion_r496284190">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSDSUOVN7OFAHYJQ7DSIEJTPANCNFSM4R3L7WRA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNS53VFNWS27536DSFDSIEJTPA5CNFSM4R3L7WRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODWXD25A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4566#discussion_r496284190",
"url": "https://github.com/bisq-network/bisq/pull/4566#discussion_r496284190",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>