<p>Refactorings and cleanups of Bisq startup code.</p>
<p>Removed the crypto policy checks as it is not needed anymore as far I am aware of (not 100% sure though).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4583'>https://github.com/bisq-network/bisq/pull/4583</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactor: Move AsciiLogo to common</li>
  <li>Refactor: extract method</li>
  <li>Refactor: add new setup method to CommonSetup with config (WIP) and call it at doExecute. Move AsciiLogo to CommonSetup</li>
  <li>Refactor: Rename setup to setupUncaughtExceptionHandler</li>
  <li>Improve handling of UncaughtExceptionHandler</li>
  <li>Refactor: Move sig int handlers to CommonSetup</li>
  <li>Refactor: Move DevEnv setup to CommonSetup</li>
  <li>Refactor: Add setup method in DevEnv</li>
  <li>Refactor: Rename onUiReadyHandler to onApplicationStartedHandler</li>
  <li>Refactor: Move periodic printSystemLoad to commonSetup</li>
  <li>Refactor: Move AvoidStandbyModeService from BisqApp to BisqExecutable.setupAvoidStandbyMode</li>
  <li>Remove empty loop</li>
  <li>Remove checkCryptoSetup as not needed anymore</li>
  <li>Remove checkCryptoPolicySetup as not needed anymore</li>
  <li>Remove Remove LimitedKeyStrengthException as not needed anymore</li>
  <li>Refactor: Rearrange methods</li>
  <li>Refactor: Move common bases setup code to CommonSetup</li>
  <li>Remove cryptoSetupFailedHandler</li>
  <li>Refactor: Move osUserDataDir method to Utilities, rename to getUserDataDir</li>
  <li>Refactor: Rename startAppSetup to runBisqSetup</li>
  <li>Improve printSystemLoad</li>
  <li>Refactor: Move handler code to domain classes</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>R</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-fa917487f8c3d1aa9a3b9eee76f5ae03">common/src/main/java/bisq/common/app/AsciiLogo.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-15c9771e37bc589db6c23a96f09b046d">common/src/main/java/bisq/common/app/DevEnv.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-7604c85a096227523692bf4f474cf5d7">common/src/main/java/bisq/common/crypto/CryptoUtils.java</a>
    (10)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-b0ee4c5aa11810914092e0c75a889c7e">common/src/main/java/bisq/common/crypto/LimitedKeyStrengthException.java</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-3bc03423f2d39ec0094b644f869cbe01">common/src/main/java/bisq/common/setup/CommonSetup.java</a>
    (73)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-92a14b1c4cdd3d65444a1858075a4e47">common/src/main/java/bisq/common/util/Profiler.java</a>
    (15)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-2766cb2f2ba0694ce0184276106f8092">common/src/main/java/bisq/common/util/Utilities.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-151b69c4f6e62667c2af489def6c96ac">core/src/main/java/bisq/core/app/BisqExecutable.java</a>
    (67)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-84f452890342bd723db5bc8caf45473c">core/src/main/java/bisq/core/app/BisqHeadlessApp.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-7661f4ba4d6ba14b0f8b186e9a6dca5e">core/src/main/java/bisq/core/app/BisqHeadlessAppMain.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-e5c845c57dc70b70babcf8032d5b0e32">core/src/main/java/bisq/core/app/BisqSetup.java</a>
    (152)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-c4d7330fa1805af1f3fd12aa13465064">core/src/main/java/bisq/core/app/WalletAppSetup.java</a>
    (80)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-04ac371732915bccd364389ca3d7d3a1">core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-50f4ec462f015eeca1788f59e768e6b2">core/src/main/java/bisq/core/filter/FilterManager.java</a>
    (31)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-b7a1bc0645ea8545a0cb75fe7ebb2425">core/src/main/java/bisq/core/setup/CoreSetup.java</a>
    (29)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-01a7cf00fcce84b3e03a47b3b1c81bbd">daemon/src/main/java/bisq/daemon/app/BisqDaemonMain.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-9b8f0c880377fee367822e838f776296">desktop/src/main/java/bisq/desktop/app/BisqApp.java</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-ec9bc1424bfac1a452063f102ef3ef5e">desktop/src/main/java/bisq/desktop/app/BisqAppMain.java</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-ce6bfda970634ec73863877d6cc61888">desktop/src/main/java/bisq/desktop/main/MainView.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-983f465fba37d94e2376c264467401b8">desktop/src/main/java/bisq/desktop/main/MainViewModel.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-ebac66b80683aa9d7c5cfc05bacd4a1a">seednode/src/main/java/bisq/seednode/SeedNodeMain.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4583/files#diff-94e8d33985ee20594ecb95b1cc764a29">statsnode/src/main/java/bisq/statistics/StatisticsMain.java</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4583.patch'>https://github.com/bisq-network/bisq/pull/4583.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4583.diff'>https://github.com/bisq-network/bisq/pull/4583.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4583">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRPL24KXHSLLCP27ELSIQBSRANCNFSM4R75BHFQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXFG7RAJ5O65SP7FN3SIQBSRA5CNFSM4R75BHF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KTXOMEA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4583",
"url": "https://github.com/bisq-network/bisq/pull/4583",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>