<p>An API convenience for getting a current offer with an offer id. Also stubbed out a <code>takeoffer</code> proto def.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/4584'>https://github.com/bisq-network/bisq/pull/4584</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add options helper for handling negative number CLI params</li>
<li>Add license comment</li>
<li>Add license comment and btc-string to satoshi converter</li>
<li>Print createoffer's reply in the CLI's console</li>
<li>Add comment to empty catch block for codacy</li>
<li>Uppercase direction & ccy-code CLI arguments in core</li>
<li>Change 'createoffer' argument order</li>
<li>Scale & convert (double) fixed price input to long</li>
<li>Move 'createoffer' price arg transform to server & test it</li>
<li>Push currencyCode.toUpperCase conversion below CoreApi</li>
<li>Convert mktPriceMargin to %, make createAndPlaceOffer private</li>
<li>Minor createoffer test changes</li>
<li>Do not reassign currencyCode parameter</li>
<li>Delete trailing spaces from blank line for codacy</li>
<li>Add simple mkt-price service & test calculated offer prices</li>
<li>Fix abs(dbl) comparison</li>
<li>Remove unused import</li>
<li>Add license comment</li>
<li>Tidy up create offer using mkt price margin % test</li>
<li>Redefine DisputeAgentType REFUNDAGENT as REFUND_AGENT</li>
<li>Fix asserts</li>
<li>Factor out duplicated OfferInfo wrapping</li>
<li>Fix 'switch statements should have a default label' codacy problem</li>
<li>Revert "Fix 'switch statements should have a default label' codacy problem"</li>
<li>Codacy requires default label in switch</li>
<li>Fix tx result handling in GrpcOffersService</li>
<li>Fix BitcoinCli wrapper create bug</li>
<li>Throw exception to CLI if attempted offer placement fails</li>
<li>Make task handler's error msg CLI friendly (needs review)</li>
<li>Check for null</li>
<li>Create 'placeoffer' method</li>
<li>Reduce verbosity of task error msg passed to CLI</li>
<li>Add api convenience 'getoffer offer-id' method</li>
<li>Fix comment</li>
<li>Fix comment, remove deprecated tag</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-2b486b2248b88650958a2fabbcc673ba">apitest/src/test/java/bisq/apitest/ApiTestCase.java</a>
(1)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-e682e7ff1d87bbe0764afc91e1c96b6d">apitest/src/test/java/bisq/apitest/method/CreateOfferTest.java</a>
(112)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-6d158dc3de2c806c8ad7b561c9eba091">apitest/src/test/java/bisq/apitest/method/MethodTest.java</a>
(37)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-f4c0c7647f8f55f67730694f7918bc77">apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java</a>
(6)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-e4e84cbe45ca5e0630bc1ac013942bda">apitest/src/test/java/bisq/apitest/method/offer/AbstractCreateOfferTest.java</a>
(125)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-44a7398e8f88ab5c8c051535bd821b27">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java</a>
(174)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-045d7fa08969e753374e280d17e6bbf0">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java</a>
(307)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-b46d7320e383c91cc66ef0c22011c1d0">apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java</a>
(63)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-c373779aeb2c0f02199d152b537b0fd1">cli/src/main/java/bisq/cli/CliMain.java</a>
(130)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-363f459105956a5f70b16fa31a07a4b5">cli/src/main/java/bisq/cli/CurrencyFormat.java</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-fc12d88e0e22b3ab3dd9dbf67fe565a7">cli/src/main/java/bisq/cli/GrpcStubs.java</a>
(3)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-a0364ea0a764fdddbf77c3b2517271b1">cli/src/main/java/bisq/cli/NegativeNumberOptions.java</a>
(81)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-46ca0d5a34640a3f705b388adb2fc8ba">cli/src/main/java/bisq/cli/TableFormat.java</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-f4cc1e47659710cf4c5b719cbe96963b">common/src/main/java/bisq/common/taskrunner/Task.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-b0245e42926f1a2d0ad4e5f5bb45d79b">common/src/main/java/bisq/common/taskrunner/TaskRunner.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-defe707a4d38994a1dd5a818fc078522">core/src/main/java/bisq/core/api/CoreApi.java</a>
(50)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-f905350d6a4eef257cb8420e5b52fcfb">core/src/main/java/bisq/core/api/CoreDisputeAgentsService.java</a>
(57)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-d7353096fea115841d9ac980fe68b3af">core/src/main/java/bisq/core/api/CoreOffersService.java</a>
(184)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-0cb7f4a1a643fec25834a24dd9e33e9a">core/src/main/java/bisq/core/api/CorePriceService.java</a>
(55)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-690160b50eded4c680fd5cbefb2deb72">core/src/main/java/bisq/core/support/dispute/agent/DisputeAgent.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-073db9176bdbf520d57c0bb69bcde77e">daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java</a>
(126)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-fce72763606c3a081cf4dc0d1e9e4542">daemon/src/main/java/bisq/daemon/grpc/GrpcPriceService.java</a>
(58)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-cf9363e58d0ea299011282758a4aa8e3">daemon/src/main/java/bisq/daemon/grpc/GrpcServer.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4584/files#diff-328b3309bc03d9ffb3ffb9e780dc7e91">proto/src/main/proto/grpc.proto</a>
(49)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/4584.patch'>https://github.com/bisq-network/bisq/pull/4584.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/4584.diff'>https://github.com/bisq-network/bisq/pull/4584.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4584">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTBPPJP3TD2HLPG2OLSISU5NANCNFSM4SAU2TLA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTVNBDYH3CY2QQPPRTSISU5NA5CNFSM4SAU2TLKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KT7PWEA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4584",
"url": "https://github.com/bisq-network/bisq/pull/4584",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>