<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4586#discussion_r498979809">p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java</a>:</p>
<pre style='color:#555'>> +        if (anyMapContainsKey(hash)) {
+            return null;
+        }
+
+        PersistableNetworkPayload previous = getMapOfLiveData().put(hash, payload);
</pre>
<p>Yes it will be always null, but we override the method signature from MapStoreService and follow the putIfAbsent signature from Map. In our special case it wil be always null. I can change it to make it more clear and add a comment.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4586#discussion_r498979809">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXWK6VCDW2V37HPJYLSIYKTNANCNFSM4SA4XR5Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQE2QYRJEYO7XZQW4TSIYKTNA5CNFSM4SA4XR52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODXRANEQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4586#discussion_r498979809",
"url": "https://github.com/bisq-network/bisq/pull/4586#discussion_r498979809",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>