<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4559#discussion_r499037694">cli/src/main/java/bisq/cli/NegativeNumberOptions.java</a>:</p>
<pre style='color:#555'>> +import java.util.Map;
+import java.util.function.Predicate;
+
+import static java.util.Arrays.stream;
+
+class NegativeNumberOptions {
+
+    private final Map<Integer, String> negativeNumberParams = new HashMap<>();
+
+    String[] removeNegativeNumberOptions(String[] args) {
+        // Cache any negative number params that will be rejected by the parser.
+        // This should be called before command line parsing.
+        for (int i = 0; i < args.length; i++) {
+            if (isNegativeNumber.test(args[i])) {
+                String param = args[i];
+                negativeNumberParams.put(i - 1, new BigDecimal(param).toString());
</pre>
<p>Wouldn't it be more natural to start the for loop at 1 then? Like <code>for (int i = 1; i < args.length; i++) {</code> since it's known that argument 0 is irrelevant and it would also make the code self explanatory.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4559#discussion_r499037694">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTXA6XFOG23QU4WMMTSIY2MVANCNFSM4RXT56GA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVQSDLI5ZCJJ6CRRTLSIY2MVA5CNFSM4RXT56GKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODXRTTXY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4559#discussion_r499037694",
"url": "https://github.com/bisq-network/bisq/pull/4559#discussion_r499037694",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>