<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4589#discussion_r499271878">common/src/main/java/bisq/common/proto/persistable/PersistableList.java</a>:</p>
<pre style='color:#555'>>      }
 
     public PersistableList(List<T> list) {
-        this.list = list;
+        setAll(list);
+    }
+
+    public void addListener(ListChangeListener<T> listener) {
+        ((ObservableList<T>) getList()).addListener(listener);
</pre>
<p>Yes, was moving the listeners later to the base class. But I think best here is to enforce observeable list as it is used anyway by all subclasses.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4589#discussion_r499271878">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXRCD2H3HXAIUSG6Q3SJCZM7ANCNFSM4SBHECQA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRTH4QULWHWXXNZKFDSJCZM7A5CNFSM4SBHECQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODXTH6QY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4589#discussion_r499271878",
"url": "https://github.com/bisq-network/bisq/pull/4589#discussion_r499271878",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>