<p>There are a number of use cases where a CLI user may want to see a single offer instead of every offer for a currency pair on the buy or sell side.  The changes are:</p>
<ul>
<li>Add <code>getoffer</code> to <code>grpc.proto</code></li>
<li>Add new method to <code>GrpcOffersService</code>, <code>CoreApi</code>, <code>CoreOffersService</code></li>
<li>Add new method to CLI</li>
<li>Adjust create offer tests to use this new convenience method</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4598'>https://github.com/bisq-network/bisq/pull/4598</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Simplify GrpcOffersService#createOffer (refactor)</li>
  <li>Fix method name</li>
  <li>Use consumer::accept instead of a countdown latch</li>
  <li>Add new getoffer(id) api method</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-6d158dc3de2c806c8ad7b561c9eba091">apitest/src/test/java/bisq/apitest/method/MethodTest.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-e4e84cbe45ca5e0630bc1ac013942bda">apitest/src/test/java/bisq/apitest/method/offer/AbstractCreateOfferTest.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-44a7398e8f88ab5c8c051535bd821b27">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java</a>
    (67)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-045d7fa08969e753374e280d17e6bbf0">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java</a>
    (88)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-c373779aeb2c0f02199d152b537b0fd1">cli/src/main/java/bisq/cli/CliMain.java</a>
    (17)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-defe707a4d38994a1dd5a818fc078522">core/src/main/java/bisq/core/api/CoreApi.java</a>
    (68)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-d7353096fea115841d9ac980fe68b3af">core/src/main/java/bisq/core/api/CoreOffersService.java</a>
    (85)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-073db9176bdbf520d57c0bb69bcde77e">daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java</a>
    (28)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4598/files#diff-328b3309bc03d9ffb3ffb9e780dc7e91">proto/src/main/proto/grpc.proto</a>
    (10)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4598.patch'>https://github.com/bisq-network/bisq/pull/4598.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4598.diff'>https://github.com/bisq-network/bisq/pull/4598.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4598">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWTTLA7IXEWMVGFY7DSJIRAZANCNFSM4SFD4VMQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQ6H3RJ6ALXGEPZYRTSJIRAZA5CNFSM4SFD4VM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KU75WHA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4598",
"url": "https://github.com/bisq-network/bisq/pull/4598",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>