<p></p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ripcurlx/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> No experience with that yet, but it seems like <code>jpackage</code> could handle that as well (via <code>--mac-sign</code> / <code>--mac-signing-keychain</code> / <code>--mac-signing-key-user-name</code>, see <a href="https://docs.oracle.com/en/java/javase/14/docs/specs/man/jpackage.html" rel="nofollow">documentation</a>).</p>
<p>Should I extend the script to ask for user input for these options and then pass them along to <code>jpackage</code>? (I assume the main thing is a path to the signing key, then maybe a signing username or identifier) Or do you have separate tools with which you want to do the signing, so we should not modify the packaging script for that purpose?</p>
</blockquote>
<p>Wasn't able to do this yesterday. I'll try to add it manually first to see if it works.<br>
I would not ask it as an option in the final implementation, but rather check if an environment variable is set, so the release process needs as little user input as possible.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4242#issuecomment-704101810">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQ273NOKLISMFJMVPDSJLFIBANCNFSM4M3JTONQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVWRVRGUGG2I3Y7KF3SJLFIBA5CNFSM4M3JTON2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFH333MQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4242#issuecomment-704101810",
"url": "https://github.com/bisq-network/bisq/pull/4242#issuecomment-704101810",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>