<p></p>
<p>FYI: this may work well with Java 10 and the current JavaFX, but it caused issues with guice in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="614036656" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4242" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4242/hovercard" href="https://github.com/bisq-network/bisq/pull/4242">#4242</a> when the packaged app contains more recent JREs (tested with Java 11, 14 and 15).</p>
<p>More specifically, when opening the packaged app:</p>
<ul>
<li>when it was packaged with this flag: starting the app just opened an empty window (with no contents whatsoever) + logs contained guice and illegal reflection exceptions</li>
<li>when it was packaged without this flag: UI worked as expected</li>
</ul>
<p>So for now I disabled it in the new jpackage script used in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="614036656" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4242" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4242/hovercard" href="https://github.com/bisq-network/bisq/pull/4242">#4242</a> with <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/696a788e5edcbca883c3546c36c997e6459b482c/hovercard" href="https://github.com/bisq-network/bisq/commit/696a788e5edcbca883c3546c36c997e6459b482c"><tt>696a788</tt></a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4600#issuecomment-705515616">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXUYH5ZFT44LDKM4VTSJWRF3ANCNFSM4SFRDE6Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTWVNUFSPN6LLLGPJ3SJWRF3A5CNFSM4SFRDE62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFIGVAYA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4600#issuecomment-705515616",
"url": "https://github.com/bisq-network/bisq/pull/4600#issuecomment-705515616",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>