<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4611#discussion_r502378415">core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java</a>:</p>
<pre style='color:#555'>> + tempPaymentMethod = String.valueOf(PaymentMethodMapper.valueOf(paymentMethod).ordinal());
+ } catch (Throwable t) {
+ tempPaymentMethod = paymentMethod;
+ }
+ this.paymentMethod = tempPaymentMethod;
+ this.date = date;
+ this.mediator = mediator;
+ this.refundAgent = refundAgent;
+ this.extraDataMap = ExtraDataMapValidator.getValidatedExtraDataMap(extraDataMap);
+
+ this.hash = hash == null ? createHash() : hash;
+ }
+
+ public byte[] createHash() {
+ // We create hash from all fields excluding hash itself. We use json as simple data serialisation.
+ // TradeDate is different for both peers so we ignore it for hash. ExtraDataMap is ignored as well as at
</pre>
<p>Date is not excluded from Json serialization. I think that's correct though since only seller is publishing.</p>
<p>I think this comment is wrong.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4611#discussion_r502379697">core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java</a>:</p>
<pre style='color:#555'>> + US_POSTAL_MONEY_ORDER,
+ CASH_DEPOSIT,
+ MONEY_GRAM,
+ WESTERN_UNION,
+ HAL_CASH,
+ F2F,
+ BLOCK_CHAINS,
+ PROMPT_PAY,
+ ADVANCED_CASH,
+ BLOCK_CHAINS_INSTANT
+ }
+
+ private final String currency;
+ private final long price;
+ private final long amount;
+ private final String paymentMethod;
</pre>
<p>Why not save this as a long? Could set first element as <code>UNKNOWN</code> for clients that haven't upgraded after a new method is added.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4611#pullrequestreview-505606917">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS5N3UOHMADPIGPTADSJ4JX3ANCNFSM4SJMV7BQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRZBM7CI76KFSW5PEDSJ4JX3A5CNFSM4SJMV7B2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODYRPGBI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4611#pullrequestreview-505606917",
"url": "https://github.com/bisq-network/bisq/pull/4611#pullrequestreview-505606917",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>