<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4608#discussion_r504985732">core/src/main/java/bisq/core/api/CoreOffersService.java</a>:</p>
<pre style='color:#555'>> @@ -67,6 +68,16 @@ public CoreOffersService(CreateOfferService createOfferService,
         this.user = user;
     }
 
+    Offer getOffer(String id) {
+        List<Offer> offers = offerBookService.getOffers().stream()
+                .filter(o -> o.getId().equals(id))
+                .collect(Collectors.toList());
</pre>
<p>Not wrong, but it's a bit odd to make list when we're looking for one element. <code>.findAny()</code> returns an <code>Optional<></code> which you could then do <code>offer.isPresent()</code> and <code>return offer.get()</code> making it clear we only expect to find one offer.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4608#pullrequestreview-508774235">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTNM5DZ23X6LY6JF7DSKYKVFANCNFSM4SHQ6AGA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSI7G6NJZUN7UKIN6TSKYKVFA5CNFSM4SHQ6AGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODZJUOWY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4608#pullrequestreview-508774235",
"url": "https://github.com/bisq-network/bisq/pull/4608#pullrequestreview-508774235",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>