<p>Based on <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/stejbac/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/stejbac">@stejbac</a> findings an offer shouldn't be removed locally when the trade is cancelled before any fees were paid.<br>
Currently this causes following warning messages when cancelling the taking of an offer.<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/96093605-a5a36c00-0ecc-11eb-9d2e-0812be562694.png"><img src="https://user-images.githubusercontent.com/170962/96093605-a5a36c00-0ecc-11eb-9d2e-0812be562694.png" alt="Screenshot from 2020-10-14 18-49-59" style="max-width:100%;"></a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4651'>https://github.com/bisq-network/bisq/pull/4651</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Only remove offer locally when necessary</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4651/files#diff-e91ddc497f0b94a9a80cc234cbdcedaf05e8f40e6e1d5fc7e9c9794f97063495">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4651/files#diff-464b973414368d42f102b402b31160515781076ccee9f6fcd7f940b1929b9c81">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java</a>
    (12)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4651.patch'>https://github.com/bisq-network/bisq/pull/4651.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4651.diff'>https://github.com/bisq-network/bisq/pull/4651.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4651">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQCTH6LLVRGVSITGQLSK2TLZANCNFSM4SRUARXQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQPQJFBNVP7L7RCP73SK2TLZA5CNFSM4SRUARX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KYKJGPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4651",
"url": "https://github.com/bisq-network/bisq/pull/4651",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>