<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>

<p>One minor comment. I think it's otherwise good.</p>
<p>To make it easier to review, it helps to keep refactorings separated in different commits. In particular pure refactor work and minor improvements are very helpful when kept separate.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4672#discussion_r509318045">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>:</p>
<pre style='color:#555'>> +    private final Predicate<ObjectProperty<Coin>> isPositiveAmount = (c) -> c.get() != null && !c.get().isZero();
+    private final Predicate<ObjectProperty<Price>> isPositivePrice = (p) -> p.get() != null && !p.get().isZero();
+    private final Predicate<ObjectProperty<Volume>> isPositiveVolume = (v) -> v.get() != null && !v.get().isZero();
</pre>
<p>Shouldn't these be <code>isNonZero...</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4672#pullrequestreview-513727007">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWDUGZTI2H226E6J3TSL3VMZANCNFSM4SYWOPUQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXDI24ULW3Y3WTC7YTSL3VMZA5CNFSM4SYWOPU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD2PNUHY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4672#pullrequestreview-513727007",
"url": "https://github.com/bisq-network/bisq/pull/4672#pullrequestreview-513727007",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>