<p></p>
<p><b>@oscarguindzberg</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4612#discussion_r510340112">core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -1183,11 +1183,8 @@ private RawTransactionInput getRawInputFromTransactionInput(@NotNull Transaction
                 "input.getConnectedOutput().getParentTransaction() must not be null");
         checkNotNull(input.getValue(), "input.getValue() must not be null");
 
-        // If we would be sure all bisq nodes migrated to bitcoinj 0.15, bitcoinSerialize(true) can be used.
-        // Since there is no way to check migration to bitcoinj 0.15,
-        // Config.SEGWIT_TRADE_PROTOCOL_ACTIVE could be checked instead.
-        // Actually, given the serialized tx is used just as the connected tx of an input,
-        // we don't need the connected tx's witness data.
+        // bitcoinSerialize(false) is used just in case the serialized tx is parsed by a bisq node still using
+        // bitcoinj 0.14. The serialized tx is just used to obtain its hash, so the witness data is not relevant.
         return new RawTransactionInput(input.getOutpoint().getIndex(),
</pre>
<p>yes, you are right, just fixed the comment to explain that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4612#discussion_r510340112">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWYPBMD66IPSZZTNKTSMBUO3ANCNFSM4SKTGGBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTZNZNGFJJH22WZ4MLSMBUO3A5CNFSM4SKTGGBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD2Y4HVA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4612#discussion_r510340112",
"url": "https://github.com/bisq-network/bisq/pull/4612#discussion_r510340112",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>