<p></p>
<p><b>@oscarguindzberg</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4612#discussion_r510205943">core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -1193,10 +1196,6 @@ private RawTransactionInput getRawInputFromTransactionInput(@NotNull Transaction
 
     private byte[] getMakersScriptSigProgram(TransactionInput transactionInput) throws TransactionVerificationException {
         byte[] scriptProgram = transactionInput.getScriptSig().getProgram();
-        if (scriptProgram.length == 0) {
-            throw new TransactionVerificationException("Inputs from maker not signed.");
-        }
-
         return scriptProgram;
</pre>
<p>This all started with scriptProgram.length == 0 being valid for a segwit input.<br>
I just removed the method and moved its content to where it was being used, i.e. takerSignsDepositTx().<br>
See takerSignsDepositTx():</p>
<pre><code>                byte[] makersScriptSigProgram = makersInput.getScriptSig().getProgram();
                if (makersScriptSigProgram.length == 0 && TransactionWitness.EMPTY.equals(makersInput.getWitness())) {
                    throw new TransactionVerificationException("Inputs from maker not signed.");
                }
</code></pre>
<p>See <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/7eb808d2bf0af0b4b292ff44289459eaabcbcde4/hovercard" href="https://github.com/bisq-network/bisq/commit/7eb808d2bf0af0b4b292ff44289459eaabcbcde4"><tt>7eb808d</tt></a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4612#discussion_r510205943">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXRADGOCZNMTAM4T5DSMA6JBANCNFSM4SKTGGBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWGR6FVCC7NWUT5DXDSMA6JBA5CNFSM4SKTGGBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD2XQPIY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4612#discussion_r510205943",
"url": "https://github.com/bisq-network/bisq/pull/4612#discussion_r510205943",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>