<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4673#discussion_r510134588">core/src/main/java/bisq/core/api/CoreTradesService.java</a>:</p>
<pre style='color:#555'>> +    Trade getTrade(String tradeId) {
+        return getTradeWithId(tradeId);
+    }
+
+    private Trade getTradeWithId(String tradeId) {
+        return tradeManager.getTradeById(tradeId).orElseThrow(() ->
+                new IllegalArgumentException(format("trade with id '%s' not found", tradeId)));
+    }
</pre>
<p>There's no need to split it, not sure why I did that.  I will change in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="726700701" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4679" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4679/hovercard" href="https://github.com/bisq-network/bisq/pull/4679">#4679</a> (the tip of the PR/branch chain).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4673#discussion_r510134588">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQQ4O55MAEK52PK4MTSMATHDANCNFSM4SYYEP2Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXYVOIXMWIQIQRZ2SDSMATHDA5CNFSM4SYYEP22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD2WYTGY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4673#discussion_r510134588",
"url": "https://github.com/bisq-network/bisq/pull/4673#discussion_r510134588",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>