<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4612#discussion_r510232664">core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -1286,11 +1286,7 @@ private void signInput(Transaction transaction, TransactionInput input, int inpu
                 input.setScriptSig(ScriptBuilder.createInputScript(txSig, sigKey));
             }
         } else if (ScriptPattern.isP2WPKH(scriptPubKey)) {
-            // TODO: Consider using this alternative way to build the scriptCode (taken from bitcoinj master)
-            // Script scriptCode = ScriptBuilder.createP2PKHOutputScript(sigKey)
-            Script scriptCode = new ScriptBuilder().data(
-                    ScriptBuilder.createOutputScript(LegacyAddress.fromKey(transaction.getParams(), sigKey)).getProgram())
-                    .build();
+            Script scriptCode = ScriptBuilder.createP2PKHOutputScript(sigKey);
</pre>
<p>Ok. Maybe a comment would be good with backgorund info.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4612#discussion_r510232664">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUQHLJ6JLXYWBPO4KTSMBCFFANCNFSM4SKTGGBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQXOK24HEY7R7LVJU3SMBCFFA5CNFSM4SKTGGBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD2XZPRQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4612#discussion_r510232664",
"url": "https://github.com/bisq-network/bisq/pull/4612#discussion_r510232664",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>