<p>Scope of this refactoring is small;  more can be done, but the short term goal of the trade utils refactoring is to share trade util logic with core api.</p>
<ul>
<li>Removed unused method getCurrencyCode()</li>
<li>Made minor style changes</li>
<li>Removed duplicated code block</li>
</ul>
<p>PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="729024238" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4699" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4699/hovercard" href="https://github.com/bisq-network/bisq/pull/4699">#4699</a> should be reviewed & merged before this PR.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4700'>https://github.com/bisq-network/bisq/pull/4700</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Block on tx-fee-request in core TakeOfferModel init</li>
  <li>Add compiler warning suppression, remove comment</li>
  <li>Add fields to grpc TradeInfo proto & wrapper</li>
  <li>Replace static TradeUtil with singleton TradeUtil</li>
  <li>Fix comment typos</li>
  <li>Refactor PendingTradesViewModel methods -> TradeUtil & OfferUtil</li>
  <li>Remove trailing spaces for codacy</li>
  <li>Refactor PendingTradesDataModel methods -> TradeUtil</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-3a9ff7695726e0660444b5b5e18600d2cff2bc2fcdf3f78c36a0fc3df504e1b6">core/src/main/java/bisq/core/api/model/OfferInfo.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-5751067b75ae6f7739df840d815386f3998f04baff5de96c079f5ce1fe6b4f57">core/src/main/java/bisq/core/api/model/TradeInfo.java</a>
    (133)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-b604ee7141fcfacf2dd0aeade4bf393c4d4d93617ab327147c363539ae804496">core/src/main/java/bisq/core/offer/OfferUtil.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-c19acb59c56bd6f03db8b9eaa772119ec8cd05b64d6a6aa86fb53f5338cf1122">core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java</a>
    (38)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-4c53004633c87a847cb5cb8296acfcff56882b3c4c502b9ee8d16ca3d81881cb">core/src/main/java/bisq/core/trade/TradeManager.java</a>
    (5)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-90839a4e0c5fc8b748e288ff7efc11d862e7ef82691c15eb00b60be56c1af7ec">core/src/main/java/bisq/core/trade/TradeUtil.java</a>
    (209)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-9c09684987dfae9f6cd0bc832ee7c5264339c0a571155b8a2b72f376f3b58608">core/src/main/java/bisq/core/trade/TradeUtils.java</a>
    (79)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-72487d9cf0255fc80f6eba13356e3212033a31088cc341022ab7f5bf6147be18">core/src/main/java/bisq/core/trade/failed/FailedTradesManager.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-9ec8e04828ae4eced641f0fb13a739df09a8e0dbb3ec809278f1e2a89f8d4a10">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java</a>
    (83)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-48b9ff1bdc7f59edec943ad00b56b091cf34548046ea14b2aff0b2e32a6d67b7">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java</a>
    (110)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4700/files#diff-dcb44a0045a5b02cde5bd2f45051b7d9293f87180111c7ea57f0d0eb85d0f393">proto/src/main/proto/grpc.proto</a>
    (29)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4700.patch'>https://github.com/bisq-network/bisq/pull/4700.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4700.diff'>https://github.com/bisq-network/bisq/pull/4700.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4700">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUJHQQ63XUTAAR5BIDSMQZHVANCNFSM4S6LXMZQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTSZXKIV6OMKSHSSNTSMQZHVA5CNFSM4S6LXMZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4K3UFNTA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4700",
"url": "https://github.com/bisq-network/bisq/pull/4700",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>