<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4692#discussion_r513086903">core/src/main/java/bisq/core/offer/takeoffer/TakeOfferModel.java</a>:</p>
<pre style='color:#555'>> @@ -141,12 +160,19 @@ private void calculateTxFees() {
         // Payout tx: 371 bytes
         // Disputed payout tx: 408 bytes
 
-        // Request actual fees:
-        log.info("Start requestTxFee: txFeeFromFeeService={}", txFeeFromFeeService);
-        feeService.requestFees(() -> {
-            txFeePerByteFromFeeService = feeService.getTxFeePerByte();
-            txFeeFromFeeService = offerUtil.getTxFeeBySize(txFeePerByteFromFeeService, feeTxSize);
-        });
+        txFeePerByteFromFeeService = getTxFeePerByte();
+        txFeeFromFeeService = offerUtil.getTxFeeBySize(txFeePerByteFromFeeService, feeTxSize);
+        log.info("{} txFeePerByte = {}", feeService.getClass().getSimpleName(), txFeePerByteFromFeeService);
+    }
+
+    private Coin getTxFeePerByte() {
+        try {
+            CompletableFuture<Void> feeRequestFuture = CompletableFuture.runAsync(feeService::requestFees);
+            feeRequestFuture.get();  // Block until async fee request is complete.
</pre>
<p>If I understand correctly (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/sqrrm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a>), you want this <code>TakeOfferModel</code> snippet changed to using a callback instead of a <code>CompletableFuture</code>.</p>
<p>Do you mind if I make this change in a later PR?  I am working on a chain of 15 pr/branches, and this is branch <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="35386871" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/1" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/1/hovercard" href="https://github.com/bisq-network/bisq/issues/1">#1</a> in the chain.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4692#discussion_r513086903">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRYGBZDZXABQVA7CEDSM5H7NANCNFSM4S4X2EAA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUUVFJXRWBAYUSH5SLSM5H7NA5CNFSM4S4X2EAKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD3RWFSY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4692#discussion_r513086903",
"url": "https://github.com/bisq-network/bisq/pull/4692#discussion_r513086903",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>