<p></p>
<p><b>@chimp1984</b> approved this pull request.</p>
<p>utACK</p>
<p>Beside 2 nits... See comments</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4733#discussion_r515555881">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>:</p>
<pre style='color:#555'>> @@ -937,6 +906,34 @@ private void activateDisplayPreferences() {
resetDontShowAgainButton.setOnAction(e -> preferences.resetDontShowAgain());
+ editCustomBtcExplorer.setOnAction(e -> {
+ EditCustomExplorerWindow urlWindow = new EditCustomExplorerWindow("BTC",
+ preferences.getBlockChainExplorer(), preferences.getBlockChainExplorers());
+ urlWindow
+ .actionButtonText("Save")
</pre>
<p>I think you forgot here to use a resource string. I guess its: <code>Res.get("shared.save")</code></p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4733#discussion_r515555901">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>:</p>
<pre style='color:#555'>> + urlWindow
+ .actionButtonText("Save")
+ .onAction(() -> {
+ preferences.setBlockChainExplorer(urlWindow.getEditedBlockChainExplorer());
+ btcExplorerTextField.setText(preferences.getBlockChainExplorer().name);
+ })
+ .closeButtonText(Res.get("shared.cancel"))
+ .onClose(urlWindow::hide)
+ .show();
+ });
+
+ editCustomBsqExplorer.setOnAction(e -> {
+ EditCustomExplorerWindow urlWindow = new EditCustomExplorerWindow("BSQ",
+ preferences.getBsqBlockChainExplorer(), preferences.getBsqBlockChainExplorers());
+ urlWindow
+ .actionButtonText("Save")
</pre>
<p>I think you forgot here to use a resource string. I guess its: Res.get("shared.save")</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4733#pullrequestreview-521181295">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTOCMDCDCQWVFBAM6LSNSRFNANCNFSM4TFUTUBA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTD6LYKCWYBNAW7FHDSNSRFNA5CNFSM4TFUTUBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD4IJQ3Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4733#pullrequestreview-521181295",
"url": "https://github.com/bisq-network/bisq/pull/4733#pullrequestreview-521181295",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>