<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>
<p>I think payid should be considered one word, more like in the original PR. It's pretty confusing with the PAY_ID_ID and as seen on <a href="https://payid.com.au/" rel="nofollow">https://payid.com.au/</a> they treat it like one word, although with odd capitalization.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ripcurlx/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> I added some suggestions as examples, but if you agree to change this, all the file names and class names and protobuf names also need to change.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516597062">core/src/main/java/bisq/core/payment/AustraliaPayID.java</a>:</p>
<pre style='color:#555'>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.core.payment;
+
+import bisq.core.locale.FiatCurrency;
+import bisq.core.payment.payload.AustraliaPayIdPayload;
+import bisq.core.payment.payload.PaymentAccountPayload;
+import bisq.core.payment.payload.PaymentMethod;
+
+public final class AustraliaPayId extends PaymentAccount {
</pre>
<p>File name should agree with class name</p>
<p>I think we should treat PayID as a single word (mentioned in another comment) and use AustraliaPayid</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516597306">core/src/main/java/bisq/core/payment/payload/AustraliaPayIDPayload.java</a>:</p>
<pre style='color:#555'>> +
+import java.util.HashMap;
+import java.util.Map;
+
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.Setter;
+import lombok.ToString;
+import lombok.extern.slf4j.Slf4j;
+
+@EqualsAndHashCode(callSuper = true)
+@ToString
+@Setter
+@Getter
+@Slf4j
+public final class AustraliaPayIdPayload extends PaymentAccountPayload {
</pre>
<p>Same file name, class name mismatch.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516597946">core/src/main/java/bisq/core/payment/payload/AustraliaPayIDPayload.java</a>:</p>
<pre style='color:#555'>> + ///////////////////////////////////////////////////////////////////////////////////////////
+ // API
+ ///////////////////////////////////////////////////////////////////////////////////////////
+
+ @Override
+ public String getPaymentDetails() {
+ return Res.get(paymentMethodId) + " - " + getPaymentDetailsForTradePopup().replace("\n", ", ");
+ }
+
+ @Override
+ public String getPaymentDetailsForTradePopup() {
+ return
+ Res.get("payment.australia.payId") + ": " + payId + "\n" +
+ Res.get("payment.account.owner") + ": " + bankAccountName;
+ }
+
</pre>
⬇️ Suggested change
<pre style="color: #555">-
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516598415">core/src/main/java/bisq/core/payment/payload/PaymentMethod.java</a>:</p>
<pre style='color:#555'>> @@ -74,6 +74,7 @@
public static final String FASTER_PAYMENTS_ID = "FASTER_PAYMENTS";
public static final String NATIONAL_BANK_ID = "NATIONAL_BANK";
public static final String JAPAN_BANK_ID = "JAPAN_BANK";
+ public static final String AUSTRALIA_PAY_ID_ID = "AUSTRALIA_PAYID";
</pre>
<p>I think PayID should be considered one word. That seems to be how it's used at <a href="https://payid.com.au/" rel="nofollow">https://payid.com.au/</a></p>
<p>Their capitalization is kind of camel case, but I think it would make more sense to treat it as a single word. It's also not an id within bisq, just part of the name of this payment method so it would make things less confusing, like</p>
⬇️ Suggested change
<pre style="color: #555">- public static final String AUSTRALIA_PAY_ID_ID = "AUSTRALIA_PAYID";
+ public static final String AUSTRALIA_PAYID_ID = "AUSTRALIA_PAYID";
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516601170">core/src/main/java/bisq/core/payment/payload/PaymentMethod.java</a>:</p>
<pre style='color:#555'>> @@ -112,6 +113,7 @@
public static PaymentMethod FASTER_PAYMENTS;
public static PaymentMethod NATIONAL_BANK;
public static PaymentMethod JAPAN_BANK;
+ public static PaymentMethod AUSTRALIA_PAY_ID;
</pre>
⬇️ Suggested change
<pre style="color: #555">- public static PaymentMethod AUSTRALIA_PAY_ID;
+ public static PaymentMethod AUSTRALIA_PAYID;
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516601870">core/src/main/java/bisq/core/payment/payload/PaymentMethod.java</a>:</p>
<pre style='color:#555'>> @@ -185,6 +187,9 @@
// Japan
JAPAN_BANK = new PaymentMethod(JAPAN_BANK_ID, DAY, DEFAULT_TRADE_LIMIT_LOW_RISK),
+ // Australia
+ AUSTRALIA_PAY_ID = new PaymentMethod(AUSTRALIA_PAY_ID_ID, DAY, DEFAULT_TRADE_LIMIT_LOW_RISK),
</pre>
⬇️ Suggested change
<pre style="color: #555">- AUSTRALIA_PAY_ID = new PaymentMethod(AUSTRALIA_PAY_ID_ID, DAY, DEFAULT_TRADE_LIMIT_LOW_RISK),
+ AUSTRALIA_PAYID = new PaymentMethod(AUSTRALIA_PAYID_ID, DAY, DEFAULT_TRADE_LIMIT_LOW_RISK),
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516602019">core/src/main/java/bisq/core/proto/CoreProtoResolver.java</a>:</p>
<pre style='color:#555'>> @@ -124,6 +125,8 @@ public PaymentAccountPayload fromProto(protobuf.PaymentAccountPayload proto) {
return InteracETransferAccountPayload.fromProto(proto);
case JAPAN_BANK_ACCOUNT_PAYLOAD:
return JapanBankAccountPayload.fromProto(proto);
+ case AUSTRALIA_PAY_ID_PAYLOAD:
</pre>
⬇️ Suggested change
<pre style="color: #555">- case AUSTRALIA_PAY_ID_PAYLOAD:
+ case AUSTRALIA_PAYID_PAYLOAD:
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516602362">core/src/main/resources/i18n/displayStrings.properties</a>:</p>
<pre style='color:#555'>> @@ -3331,6 +3331,11 @@ payment.japan.bank=Bank
payment.japan.branch=Branch
payment.japan.account=Account
payment.japan.recipient=Name
+payment.australia.payId=PayID
</pre>
⬇️ Suggested change
<pre style="color: #555">-payment.australia.payId=PayID
+payment.australia.payid=PayID
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4742#discussion_r516603665">desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java</a>:</p>
<pre style='color:#555'>> @@ -457,6 +470,8 @@ private PaymentMethodForm getPaymentMethodForm(PaymentMethod paymentMethod, Paym
return new SpecificBankForm(paymentAccount, accountAgeWitnessService, inputValidator, root, gridRow, formatter);
case PaymentMethod.JAPAN_BANK_ID:
return new JapanBankTransferForm(paymentAccount, accountAgeWitnessService, japanBankTransferValidator, inputValidator, root, gridRow, formatter);
+ case PaymentMethod.AUSTRALIA_PAY_ID_ID:
</pre>
⬇️ Suggested change
<pre style="color: #555">- case PaymentMethod.AUSTRALIA_PAY_ID_ID:
+ case PaymentMethod.AUSTRALIA_PAYID_ID:
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4742#pullrequestreview-522403907">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSHICCPDN7YAIRTYZDSN7UA3ANCNFSM4TITAD3A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWN4BK4J4EDFAU2H7DSN7UA3A5CNFSM4TITAD3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD4RUAQY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4742#pullrequestreview-522403907",
"url": "https://github.com/bisq-network/bisq/pull/4742#pullrequestreview-522403907",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>