<p></p>
<p><b>@ripcurlx</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4744#discussion_r517870563">core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java</a>:</p>
<pre style='color:#555'>>
- log.debug("accountAgeCategory={}, limit={}, factor={}, accountAgeWitnessHash={}",
- accountAgeCategory,
- Coin.valueOf(limit).toFriendlyString(),
- factor,
- Utilities.bytesAsHexString(accountAgeWitness.getHash()));
- return limit;
+ double factor;
+ boolean isRisky = PaymentMethod.hasChargebackRisk(paymentMethod, currencyCode);
+ if (!isRisky || direction == OfferPayload.Direction.SELL) {
+ // Get age of witness rather than time since signing for non risky payment methods and for selling
+ accountAgeCategory = getAccountAgeCategory(getAccountAge(accountAgeWitness, new Date()));
+ }
+ long limit = OfferRestrictions.TOLERATED_SMALL_TRADE_AMOUNT.value;
+ if (direction == OfferPayload.Direction.BUY && isRisky) {
+ // Used only for bying of BTC with risky payment methods
</pre>
<p>Nit: Just a little typo in the old code <code>buying</code> vs <code>bying</code></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4744#pullrequestreview-524022441">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXT6XNLOCOSMLWIW63SOJPEZANCNFSM4TI52GKQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQHZWUZ5LLWUU2HFMTSOJPEZA5CNFSM4TI52GK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD457FKI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4744#pullrequestreview-524022441",
"url": "https://github.com/bisq-network/bisq/pull/4744#pullrequestreview-524022441",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>