<p>This PR completes the improvements to trading charts introduced in PRs <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="730748630" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4715" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4715/hovercard" href="https://github.com/bisq-network/bisq/pull/4715">#4715</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="734802526" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4740" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4740/hovercard" href="https://github.com/bisq-network/bisq/pull/4740">#4740</a>, by formatting the Y-axis values as:</p>
<ul>
<li>Fiat: Apply separator format to numbers</li>
<li>Crypto: remove some (not all) trailing zeroes from fractional part</li>
</ul>
<p>Here is the result for the EUR chart, similar for other fiat:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98438133-d2742900-20f0-11eb-8963-fe14c491cf07.png"><img src="https://user-images.githubusercontent.com/142019/98438133-d2742900-20f0-11eb-8963-fe14c491cf07.png" alt="Bisq-charts-Yaxis_EUR-day-2020-11-04" style="max-width:100%;"></a></p>
<p>Below are before and after for various cryptos:<br>
XMR before:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98438212-6c3bd600-20f1-11eb-8579-dd9b6e8f8f36.png"><img src="https://user-images.githubusercontent.com/142019/98438212-6c3bd600-20f1-11eb-8579-dd9b6e8f8f36.png" alt="Bisq-charts-Yaxis_XMR0-day-2020-11-05" style="max-width:100%;"></a><br>
XMR after:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98438228-82e22d00-20f1-11eb-8c71-b359f5a3ec0e.png"><img src="https://user-images.githubusercontent.com/142019/98438228-82e22d00-20f1-11eb-8c71-b359f5a3ec0e.png" alt="Bisq-charts-Yaxis_XMR-day-2020-11-05" style="max-width:100%;"></a><br>
BSQ before:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98438299-eec49580-20f1-11eb-8caa-ae23a3b7763e.png"><img src="https://user-images.githubusercontent.com/142019/98438299-eec49580-20f1-11eb-8caa-ae23a3b7763e.png" alt="Bisq-charts-Yaxis_BSQ0-day-2020-11-05" style="max-width:100%;"></a><br>
BSQ after<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98438303-fa17c100-20f1-11eb-9c62-d27bcb399e9e.png"><img src="https://user-images.githubusercontent.com/142019/98438303-fa17c100-20f1-11eb-9c62-d27bcb399e9e.png" alt="Bisq-charts-Yaxis_BSQ-day-2020-11-05" style="max-width:100%;"></a><br>
ETH before:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98438333-27fd0580-20f2-11eb-873e-86b4d72f2174.png"><img src="https://user-images.githubusercontent.com/142019/98438333-27fd0580-20f2-11eb-873e-86b4d72f2174.png" alt="Bisq-charts-Yaxis_ETH0-week-2020-11-05" style="max-width:100%;"></a><br>
ETH after:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98438353-3a773f00-20f2-11eb-80d9-9af018e1e2cd.png"><img src="https://user-images.githubusercontent.com/142019/98438353-3a773f00-20f2-11eb-80d9-9af018e1e2cd.png" alt="Bisq-charts-Yaxis_ETH-week-2020-11-05" style="max-width:100%;"></a></p>
<p>What do you think ?</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/4761'>https://github.com/bisq-network/bisq/pull/4761</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Format fiat currency tick mark label on Y-axis.</li>
<li>Remove trailing zeroes from crypto y-axis tick labels.</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4761/files#diff-c07a4a25261a735296715e03648489d434fb39f93d11500ed770a58f21a8623e">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java</a>
(8)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/4761.patch'>https://github.com/bisq-network/bisq/pull/4761.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/4761.diff'>https://github.com/bisq-network/bisq/pull/4761.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4761">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXLJZNDQZ3KOEW6GODSOUMZDANCNFSM4TNR4QRA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVABTMBFS35NECV7TLSOUMZDA5CNFSM4TNR4QRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LAAH5RQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4761",
"url": "https://github.com/bisq-network/bisq/pull/4761",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>