<h2>Intro</h2>
<p>This is an attempt to simplify the Market Offers chart, to provide a better (I think) visual "feeling".<br>
In particular, the scientific precision of the X-axis values is confusing to the user:</p>
<p>For example, for EUR this:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98598945-e469ed80-22e3-11eb-9929-703b192189b5.png"><img src="https://user-images.githubusercontent.com/142019/98598945-e469ed80-22e3-11eb-9929-703b192189b5.png" alt="Bisq-MarketOfferBook-EURold-2020-11-09" style="max-width:100%;"></a><br>
becomes:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98599008-fb104480-22e3-11eb-8c79-576f895c15c0.png"><img src="https://user-images.githubusercontent.com/142019/98599008-fb104480-22e3-11eb-8c79-576f895c15c0.png" alt="Bisq-MarketOfferBook-EURnew-2020-11-09" style="max-width:100%;"></a></p>
<p>For XMR:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98600419-3449b400-22e6-11eb-9f8f-7877b79d03c3.png"><img src="https://user-images.githubusercontent.com/142019/98600419-3449b400-22e6-11eb-9f8f-7877b79d03c3.png" alt="Bisq-MarketOfferBook-default-XMR-2020-11-08" style="max-width:100%;"></a><br>
becomes:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98600531-5fcc9e80-22e6-11eb-97b5-9dafa3d0ac89.png"><img src="https://user-images.githubusercontent.com/142019/98600531-5fcc9e80-22e6-11eb-97b5-9dafa3d0ac89.png" alt="Bisq-MarketOfferBook-new-XMR-2020-11-08" style="max-width:100%;"></a></p>
<p>For GBP:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98600994-10d33900-22e7-11eb-937b-2e77292cd82e.png"><img src="https://user-images.githubusercontent.com/142019/98600994-10d33900-22e7-11eb-937b-2e77292cd82e.png" alt="Bisq-MarketOfferBook-GBPold-2020-11-09" style="max-width:100%;"></a><br>
becomes:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98601027-1fb9eb80-22e7-11eb-9de4-d1b1a3b6fa69.png"><img src="https://user-images.githubusercontent.com/142019/98601027-1fb9eb80-22e7-11eb-9de4-d1b1a3b6fa69.png" alt="Bisq-MarketOfferBook-GBPnew-2020-11-09" style="max-width:100%;"></a></p>
<h2>The BSQ problem</h2>
<p>The above works well (my opinion of course) for the remaining currencies (including USD, which I forgot to capture a pic - sorry), except for BSQ.<br>
BSQ offers have some crazy values. The current charts implementation, filters-out values that have a factor 3 difference, the outliers are removed.<br>
In the current PR, the filtering-out has been removed. I believe if there is a problem, the data should show it, not hide it. Hiding bad data creates a false sense of OKness. Better to see it:<br>
Current BSQ chart:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98604344-2ac34a80-22ec-11eb-8d22-703d5a88d547.png"><img src="https://user-images.githubusercontent.com/142019/98604344-2ac34a80-22ec-11eb-8d22-703d5a88d547.png" alt="Bisq-MarketOfferBook-BSQold-2020-11-09" style="max-width:100%;"></a><br>
becomes:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98604387-3ca4ed80-22ec-11eb-90e2-0312ccc5cc83.png"><img src="https://user-images.githubusercontent.com/142019/98604387-3ca4ed80-22ec-11eb-90e2-0312ccc5cc83.png" alt="Bisq-MarketOfferBook-BSQnew-2020-11-09" style="max-width:100%;"></a></p>
<p>Looking at the Sell BTC (red) table, we see the last few values represent orders of magnitude jumps from the main core.<br>
Putting back the filtering is easy, as is taking it off. I hope a discussion on how to best handle this issue follows. Is there one ongoing, already ?</p>
<p>Perhaps an outliers-toggle switch like in that other DAO chart on BSQs.</p>
<h2>The translations</h2>
<p>The Y-axis label is "BTC Offer Volume". As a multi-lingual configuration is used on this chart, a translation web service was used to provide stock translations, which probably sometimes fail miserably. I don't know the Bisq policy on this, please advice.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/4774'>https://github.com/bisq-network/bisq/pull/4774</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Format fiat currency tick mark label on Y-axis.</li>
<li>Remove trailing zeroes from crypto y-axis tick labels.</li>
<li>Improve view of market offers chart.</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-c8a7a637dd96f15ef14955c1520e9f38361c4887abf1b63bd05dab16b9e59b9b">core/src/main/java/bisq/core/locale/CurrencyUtil.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-a6cc570e0f56a36136791beae8f497706216230467708be9343344cd953e5f08">core/src/main/resources/i18n/displayStrings.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-8639f2e8a3ed84906aed18225e3ff08e946a20286357641f84e4af5b5e10de2a">core/src/main/resources/i18n/displayStrings_de.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-771d11253126ac95034aed5f0c3efd6d5dabf4fe67df30a4d89212aefcecb0d4">core/src/main/resources/i18n/displayStrings_es.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-77420258222f2802c63e62a6c56c8aba875e2ff54547dd65f08a7ebf5ffb6931">core/src/main/resources/i18n/displayStrings_fa.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-b6538c98c770ecd4c7fcc02ee7290ba86888b2656a16a12f69c388cf125b1b74">core/src/main/resources/i18n/displayStrings_fr.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-82a57bf7b2e06b898f6e5cb08db6890919248052455d8131c1233b3fc52de779">core/src/main/resources/i18n/displayStrings_ja.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-14f8cf55408f39244df3add1d811e9251347f557d64f8e8361c26cd2b54bdb1e">core/src/main/resources/i18n/displayStrings_pt-br.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-3a802df8ba7d6cd298ad195e3421a58bae6915e22c558419de16d588cad2d9bc">core/src/main/resources/i18n/displayStrings_pt.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-0507bfa776dad75a011eee1004c97469a4c2af417c4e60a8282f750906c46c6b">core/src/main/resources/i18n/displayStrings_ru.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-8a4626459c463132f8bf78f43419482231dfcda46d9f17e6fc33b57f15d5273d">core/src/main/resources/i18n/displayStrings_th.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-3ea9b4d13365abb4360bc24b8f8e94cdb8652b1f005da8b3ea51e9d3aaf8c4b3">core/src/main/resources/i18n/displayStrings_vi.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-f4bccde907ad97ce3b26f93b715899ada3f0c5d7679180424923c5576537b2db">core/src/main/resources/i18n/displayStrings_zh-hans.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-6e3f9c90ae5c39d59dd3ad4e4b65328bc460a8f769d32ca381470621d24f7a56">core/src/main/resources/i18n/displayStrings_zh-hant.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-e40629ebbd042a7edf118df98833f41b5282224e03d5c62863a27fe56bc6109f">desktop/src/main/java/bisq/desktop/bisq.css</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-8e32f8ec1c4ae10c202b2b0e86ca1bf0e6e1de7c7890b4b110f41e77e84a5470">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java</a>
(29)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4774/files#diff-c07a4a25261a735296715e03648489d434fb39f93d11500ed770a58f21a8623e">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java</a>
(8)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/4774.patch'>https://github.com/bisq-network/bisq/pull/4774.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/4774.diff'>https://github.com/bisq-network/bisq/pull/4774.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4774">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWEKCF4UOXMKHDTPHLSPBYU3ANCNFSM4TP6OFHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVJUX3YELKKW2R4UBTSPBYU3A5CNFSM4TP6OFH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LAS3RVQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4774",
"url": "https://github.com/bisq-network/bisq/pull/4774",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>