<h2>Intro</h2>
<p>The BSQ supply page on the DAO GUI tab, provides 3 charts and some numerical data (not statistics) on the BSQ supply.<br>
For simplicity, I will refer here to the charts as chart#1 (top), chart#2 (middle) and chart#3 (bottom) to avoid any confusion with the names.<br>
The charts and the page itself seems a little confusing. I decided to do some touch-ups to improve it. This is not a redesign of the page.</p>
<h2>Current Status</h2>
<p>The DAO BSQ pages, as of version 1.42 is like this:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98921446-fb723080-24d9-11eb-9454-20d8057e55fe.png"><img src="https://user-images.githubusercontent.com/142019/98921446-fb723080-24d9-11eb-9454-20d8057e55fe.png" alt="Bisq-Dao-Page-BSQ_Supply_top-2020-11-08" style="max-width:100%;"></a><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98921479-075df280-24da-11eb-8af6-09415f6323c5.png"><img src="https://user-images.githubusercontent.com/142019/98921479-075df280-24da-11eb-8af6-09415f6323c5.png" alt="Bisq-Dao-Page-BSQ_Supply_bottom-2020-11-08" style="max-width:100%;"></a></p>
<h2>Results</h2>
<p>The result of this PR is currently:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98922113-c0bcc800-24da-11eb-8c2a-ff06e78acb77.png"><img src="https://user-images.githubusercontent.com/142019/98922113-c0bcc800-24da-11eb-8c2a-ff06e78acb77.png" alt="Bisq-Dao-Page-BSQ_Supply_NEW_top-2020-11-12" style="max-width:100%;"></a><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/142019/98923219-0e860000-24dc-11eb-8420-7418eee13dc7.png"><img src="https://user-images.githubusercontent.com/142019/98923219-0e860000-24dc-11eb-8420-7418eee13dc7.png" alt="Bisq-Dao-Page-BSQ_Supply_NEW_bottom-2020-11-12" style="max-width:100%;"></a></p>
<h2>Description of changes</h2>
<ol>
<li>Chart touch-ups affect the display of lines and axes.</li>
<li>Removed Chart#2, it has no new information from Chart#1, so it is not needed.</li>
<li>Did not:
<ul>
<li>Check or touch any of the calculations in the number sections.</li>
<li>Removed chart#2 by commenting-out the relevant code and left as a placeholder. Easy to re-insert another chart in its place if/when needed.</li>
</ul>
</li>
</ol>
<h3>Remaining issues</h3>
<ol>
<li>Chart#1 is a monthly summary, does not align well with the tick marks. Can be worked on.</li>
<li>Section <strong>BSQ burnt</strong> show a negative number for <em>Burned BSQ (fees)</em>. <strong>Q:</strong> Is that by design ?</li>
</ol>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/4785'>https://github.com/bisq-network/bisq/pull/4785</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Improve view of market offers chart</li>
<li>Touch ups on the DAO BSQ supply page.</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4785/files#diff-c8a7a637dd96f15ef14955c1520e9f38361c4887abf1b63bd05dab16b9e59b9b">core/src/main/java/bisq/core/locale/CurrencyUtil.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4785/files#diff-a6cc570e0f56a36136791beae8f497706216230467708be9343344cd953e5f08">core/src/main/resources/i18n/displayStrings.properties</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4785/files#diff-e40629ebbd042a7edf118df98833f41b5282224e03d5c62863a27fe56bc6109f">desktop/src/main/java/bisq/desktop/bisq.css</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4785/files#diff-1b240ce1c531824735ed38cf2b2b4aa4521d2b811ee3c195da902fe3858d3729">desktop/src/main/java/bisq/desktop/main/dao/economy/supply/SupplyView.java</a>
(91)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4785/files#diff-8e32f8ec1c4ae10c202b2b0e86ca1bf0e6e1de7c7890b4b110f41e77e84a5470">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java</a>
(50)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/4785.patch'>https://github.com/bisq-network/bisq/pull/4785.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/4785.diff'>https://github.com/bisq-network/bisq/pull/4785.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4785">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVITKRJTIRWJJPFGH3SPOXY7ANCNFSM4TTCMSGA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRHPIEHOMT2YNWBNE3SPOXY7A5CNFSM4TTCMSGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LBRZ4DQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4785",
"url": "https://github.com/bisq-network/bisq/pull/4785",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>