<p></p>
<blockquote>
<p>With the persistence call in complete() it's not necessary to persist in each trade task.</p>
</blockquote>
<p>A reason why I did not do want to rely only on complete is as there are async tasks and i want to be sure that if the task never completes (shutdown) that the intermediate state change is persisted. But also not happy that its that verbose now ;-(. But its more similar as it was before, just that some calls have been done inside the trade setter methods.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4816#issuecomment-730470802">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQXGR5QWUKMNUU2AQTSQU6IPANCNFSM4TZIQBTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTJQUJ2TNETY2T2RULSQU6IPA5CNFSM4TZIQBT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFOFBTEQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4816#issuecomment-730470802",
"url": "https://github.com/bisq-network/bisq/pull/4816#issuecomment-730470802",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>