<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>
<p>utACK</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4818#discussion_r533350653">apitest/src/test/java/bisq/apitest/method/payment/GetPaymentMethodsTest.java</a>:</p>
<pre style='color:#555'>> + public static void setUp() {
+ try {
+ setUpScaffold(bitcoind, alicedaemon);
+ } catch (Exception ex) {
+ fail(ex);
+ }
+ }
+
+ @Test
+ @Order(1)
+ public void testGetPaymentMethods() {
+ List<String> paymentMethodIds = getPaymentMethods(alicedaemon)
+ .stream()
+ .map(p -> p.getId())
+ .collect(Collectors.toList());
+ assertTrue(paymentMethodIds.size() > 25);
</pre>
<p>This seems like a fragile test as we continuously change the paymentMethods</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4818#pullrequestreview-541820918">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVMYMOKSCIQRNIQAPLSSTKTBANCNFSM4T2C2S3A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRBTW6MDHOB5FM3DH3SSTKTBA5CNFSM4T2C2S3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEBFYP5Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4818#pullrequestreview-541820918",
"url": "https://github.com/bisq-network/bisq/pull/4818#pullrequestreview-541820918",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>