<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4858#discussion_r533598664">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>:</p>
<pre style='color:#555'>> +            CompletableFuture<Void> feeRequestFuture = CompletableFuture.runAsync(feeService::requestFees);
+            feeRequestFuture.get();  // Block until async fee request is complete.
+        } catch (InterruptedException | ExecutionException e) {
+            throw new IllegalStateException("could not request fees from fee service.", e);
+        }
+
+        Coin stdTxFeeRate = feeService.getTxFeePerVbyte();
+        Coin customTxFeeRate = preferences.isUseCustomWithdrawalTxFee()
+                ? Coin.valueOf(preferences.getWithdrawalTxFeeInVbytes())
+                : Coin.NEGATIVE_SATOSHI;
+
+        return new TxFeeRateInfo(stdTxFeeRate.value, customTxFeeRate.value);
+    }
+
+    TxFeeRateInfo setTxFeeRatePreference(long txFeeRate) {
+        if (txFeeRate <= 0)
</pre>
<p>Doing this check here makes the CLI's error msg stylistically consistent with others.</p>
<p>This brings up a general issue that is going to need quite a bit of work in the API:  displaying validation error messages coming from the server's core, in the CLI.    But for now, getting all the v1 methods working for correct parameters is the short term priority.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4858#discussion_r533598664">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVOGN5ZCBD37R2C5T3SSUS2JANCNFSM4UEFZYHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRGQCLMZTDESPZQZQDSSUS2JA5CNFSM4UEFZYH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEBIG5KQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4858#discussion_r533598664",
"url": "https://github.com/bisq-network/bisq/pull/4858#discussion_r533598664",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>