<p></p>
<p><b>@sqrrm</b> approved this pull request.</p>

<p>utACK</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4889#discussion_r535660465">core/src/main/java/bisq/core/trade/protocol/BuyerAsMakerProtocol.java</a>:</p>
<pre style='color:#555'>>                          MakerRemovesOpenOffer.class,
+                        BuyerProcessDelayedPayoutTxSignatureRequest.class,
</pre>
<p>Could this be abused by sending a bad request, causing offers to be removed but guaranteed failed trade?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4889#discussion_r535666790">core/src/main/java/bisq/core/trade/TradeManager.java</a>:</p>
<pre style='color:#555'>>          }
         TradeProtocol tradeProtocol = TradeProtocolFactory.getNewTradeProtocol(trade);
-        tradeProtocolByTradeId.put(trade.getId(), tradeProtocol);
+        TradeProtocol prev = tradeProtocolByTradeId.put(trade.getUid(), tradeProtocol);
+        if (prev != null) {
+            log.error("We had already an entry with uid {}", trade.getUid());
</pre>
<p>How would this happen? Collision of randomUUID?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4889#pullrequestreview-544480774">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNULOXYKCCSB4DRXNLLSTACSJANCNFSM4UMOUGOQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNS7KS3EKVJBRLYAHDDSTACSJA5CNFSM4UMOUGO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEB2B4BQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4889#pullrequestreview-544480774",
"url": "https://github.com/bisq-network/bisq/pull/4889#pullrequestreview-544480774",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>