<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #4873.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="755381048" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4873" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4873/hovercard" href="https://github.com/bisq-network/bisq/issues/4873">#4873</a></p>
<p>Beside what is mentioned in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="755381048" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4873" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4873/hovercard" href="https://github.com/bisq-network/bisq/issues/4873">#4873</a> I found another (minor) issue. We use an immutable list for address entries but the coinLockedInMultiSig value was set in the object via a setter. This change would be lost when accessed as when one open the wallet tool with cmd+j (after take offe the value was 0 there instead of the locked up funds). As the field is only used for lookup for locked funds from failed trades the bug was not very visible.<br>
coinLockedInMultiSig is now a final field set by the constructor.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4883'>https://github.com/bisq-network/bisq/pull/4883</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Apply project format rules (no code change)</li>
  <li>- revent that a wrong tx is set as deposit tx</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-0acc7d00f8368b0f79485d84162b2beb9487b061fd2d31aeb529e06d7c10d299">core/src/main/java/bisq/core/app/BisqSetup.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-dc1f9cb827b6b1801bd28e17eccd8431e01e86f9cc3cf38d9746719ae57508a5">core/src/main/java/bisq/core/btc/Balances.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-a0a115e1e0d8099694144619f5bf039ee2b038e9137c43bacfb62a7fb1602e4d">core/src/main/java/bisq/core/btc/model/AddressEntry.java</a>
    (50)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-5a4c1078481e57b710b7bfecef9826e7870c277244aaefea729d96e662e8af7e">core/src/main/java/bisq/core/btc/model/AddressEntryList.java</a>
    (27)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-75820b5165905d1e3a47d5fe31e4b5dba017c6b25a322aad955ffa592a67b362">core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java</a>
    (58)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-8d23c85a8f98e22217f104cde889c862e815a61b9f5c02996ec342e10c2ae4e5">core/src/main/java/bisq/core/trade/protocol/tasks/SetupPayoutTxListener.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-bdc42a6654821632284ecaf0712abb5ced3c8f6844dc13d63e972bac6df95689">core/src/main/java/bisq/core/trade/protocol/tasks/arbitration/PublishedDelayedPayoutTx.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-27c9be225f5c82e3caab312f6206ccddd7a1c672764fdf1d018bd4d69fc7118c">core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-e2f35c4d278aa1e9dc089aca7de1f9792ca81c31f1cc9f62305fa6ce2d8ceaa3">core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerSetupDepositTxListener.java</a>
    (67)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-0fefac563214e121b40ff47a1dd203418147307565f2eeef66054d9edeb688ac">core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-7e9275e958ec5c25866b75090f3cf5e688d01b2d13dc5ddd7f4a071e2b05bba4">core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerSignsDepositTx.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-f73eccda3d628fc4884fc1b006b8c511c2f72d74893c435dc18f16310a43725e">core/src/main/java/bisq/core/trade/protocol/tasks/mediation/FinalizeMediatedPayoutTx.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-1f11665bffe7fac0e34bd6bb615b8282c214baaedb81b7c0c803c23cc39140fc">core/src/main/java/bisq/core/trade/protocol/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-441839ce8f6a0ce565367662c9437901c9968b60704dad46f13b55b3217eeea2">core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerSignAndFinalizePayoutTx.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-d6ffb9a14075f2fa86f6cce06c125fb3e0724d5f1206cc9537492369529a303d">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_maker/SellerAsMakerCreatesUnsignedDepositTx.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-dd9ec47b40ab794541022ff79531e83953cbccd542d6491f491533a5a7312456">core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerSignsDepositTx.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4883/files#diff-e80a275fb99bce9c523138bec6cbb5949be5b522fa800e8de1bc2e8fe3d2c627">desktop/src/main/java/bisq/desktop/main/funds/locked/LockedListItem.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4883.patch'>https://github.com/bisq-network/bisq/pull/4883.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4883.diff'>https://github.com/bisq-network/bisq/pull/4883.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4883">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVU42QQ4IO33PCAM2TSS6SIHANCNFSM4UMDF57A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWO6H3MKTVOPCEVY43SS6SIHA5CNFSM4UMDF57KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LIT3ADA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4883",
"url": "https://github.com/bisq-network/bisq/pull/4883",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>