<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4851#discussion_r536195424">core/src/main/java/bisq/core/dao/node/lite/network/RequestBlocksHandler.java</a>:</p>
<pre style='color:#555'>> }
+
+ GetBlocksResponse getBlocksResponse = (GetBlocksResponse) networkEnvelope;
+ if (getBlocksResponse.getRequestNonce() != nonce) {
+ log.warn("Nonce not matching. That can happen rarely if we get a response after a canceled " +
+ "handshake (timeout causes connection close but peer might have sent a msg before " +
+ "connection was closed).\n\t" +
+ "We drop that message. nonce={} / requestNonce={}",
+ nonce, getBlocksResponse.getRequestNonce());
+ return;
+ }
+
+ cleanup();
</pre>
<p>cleanup calls stopTimeoutTimer. But will consolidate cancel/stop/cleanup</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4851#discussion_r536195424">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWIKLIHMFBDXGOUPC3STEALFANCNFSM4UD52FOA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTC2CJIPHKUOPUVRHLSTEALFA5CNFSM4UD52FOKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEB6TLII.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4851#discussion_r536195424",
"url": "https://github.com/bisq-network/bisq/pull/4851#discussion_r536195424",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>