<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4851#discussion_r536198851">core/src/main/java/bisq/core/dao/node/lite/network/RequestBlocksHandler.java</a>:</p>
<pre style='color:#555'>> @@ -168,31 +167,36 @@ public void onFailure(@NotNull Throwable throwable) {
     @Override
     public void onMessage(NetworkEnvelope networkEnvelope, Connection connection) {
         if (networkEnvelope instanceof GetBlocksResponse) {
</pre>
<p>I prefer to not return early here as this style is commonly used in many places and often there are several if else branches. It is more like a dispatcher or switch case style (if switch would be more flexible in java). I prefer to use the early return for validation use cases but here its more to select the msg we are interested in.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4851#discussion_r536198851">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTM64LUZUU6MWNFA3LSTEA4PANCNFSM4UD52FOA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQB57IXTPDLUXM7NYLSTEA4PA5CNFSM4UD52FOKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEB6UMDI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4851#discussion_r536198851",
"url": "https://github.com/bisq-network/bisq/pull/4851#discussion_r536198851",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>