<p>We got some reports where users have no deposit tx displayed in the<br>
trade after spv resync but cannot move the trade to failed trades.<br>
It seems the invalid txId is still stored in the trade but the tx itself<br>
got removed from the wallet after reysnc. We check not that both the tx<br>
and the txId need to be present.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4921'>https://github.com/bisq-network/bisq/pull/4921</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Check also for depositTxId in trade and check if both</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4921/files#diff-0399e1caaadecbe847e18f0eda2ca8bf60f9777bc3bc30840e3af493601260b1">core/src/main/java/bisq/core/trade/Trade.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4921/files#diff-05dd42f811971fd710447d354bb018666cbb56dc76d95f64e07ba9e800b512d3">desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java</a>
    (13)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4921.patch'>https://github.com/bisq-network/bisq/pull/4921.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4921.diff'>https://github.com/bisq-network/bisq/pull/4921.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4921">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRQR7SNTJ3SGOGBF3LST2QJFANCNFSM4USTGH4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWJCMYTOZD5GIXV3GLST2QJFA5CNFSM4USTGH4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LKJ7PSA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4921",
"url": "https://github.com/bisq-network/bisq/pull/4921",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>