<p>So we map those setters to our UserThread.</p>
<p>How to reproduce issue?<br>
Restore from seed triggered following exception:</p>
<p>Dec-08 13:20:04.547 [ STARTING] ERROR bisq.common.setup.CommonSetup: Stack trace:<br>
java.lang.IllegalStateException: Not on FX application thread; currentThread =  STARTING<br>
at com.sun.javafx.tk.Toolkit.checkFxUserThread(Toolkit.java:291)<br>
at com.sun.javafx.tk.quantum.QuantumToolkit.checkFxUserThread(QuantumToolkit.java:424)<br>
at javafx.scene.Parent$3.onProposedChange(Parent.java:471)<br>
at com.sun.javafx.collections.VetoableListDecorator.setAll(VetoableListDecorator.java:113)<br>
at com.sun.javafx.collections.VetoableListDecorator.setAll(VetoableListDecorator.java:108)<br>
at javafx.scene.control.skin.LabeledSkinBase.updateChildren(LabeledSkinBase.java:272)<br>
at javafx.scene.control.skin.LabeledSkinBase.lambda$new$11(LabeledSkinBase.java:220)<br>
at com.sun.javafx.scene.control.LambdaMultiplePropertyChangeListenerHandler.lambda$new$1(LambdaMultiplePropertyChangeListenerHandler.java:49)<br>
at javafx.beans.value.WeakChangeListener.changed(WeakChangeListener.java:86)<br>
at com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(ExpressionHelper.java:181)<br>
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)<br>
at javafx.beans.property.StringPropertyBase.fireValueChangedEvent(StringPropertyBase.java:104)<br>
at javafx.beans.property.StringPropertyBase.markInvalid(StringPropertyBase.java:111)<br>
at javafx.beans.property.StringPropertyBase.access$000(StringPropertyBase.java:50)<br>
at javafx.beans.property.StringPropertyBase$Listener.invalidated(StringPropertyBase.java:231)<br>
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136)<br>
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)<br>
at javafx.beans.property.StringPropertyBase.fireValueChangedEvent(StringPropertyBase.java:104)<br>
at javafx.beans.property.StringPropertyBase.markInvalid(StringPropertyBase.java:111)<br>
at javafx.beans.property.StringPropertyBase.access$000(StringPropertyBase.java:50)<br>
at javafx.beans.property.StringPropertyBase$Listener.invalidated(StringPropertyBase.java:231)<br>
at com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:348)<br>
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)<br>
at javafx.beans.property.StringPropertyBase.fireValueChangedEvent(StringPropertyBase.java:104)<br>
at javafx.beans.property.StringPropertyBase.markInvalid(StringPropertyBase.java:111)<br>
at javafx.beans.property.StringPropertyBase.set(StringPropertyBase.java:145)<br>
at javafx.beans.property.StringPropertyBase.set(StringPropertyBase.java:50)<br>
at bisq.core.app.WalletAppSetup.lambda$init$1(WalletAppSetup.java:170)<br>
at com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(ExpressionHelper.java:181)<br>
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)<br>
at javafx.beans.binding.ObjectBinding.invalidate(ObjectBinding.java:170)<br>
at com.sun.javafx.binding.BindingHelperObserver.invalidated(BindingHelperObserver.java:52)<br>
at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136)<br>
at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)<br>
at javafx.beans.property.IntegerPropertyBase.fireValueChangedEvent(IntegerPropertyBase.java:107)<br>
at javafx.beans.property.IntegerPropertyBase.markInvalid(IntegerPropertyBase.java:114)<br>
at javafx.beans.property.IntegerPropertyBase.set(IntegerPropertyBase.java:148)<br>
at bisq.core.btc.setup.WalletsSetup$1.onSetupCompleted(WalletsSetup.java:245)</p>

<p>Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr</p>
<p>Your PR description here.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/4916'>https://github.com/bisq-network/bisq/pull/4916</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Property fields must not bet set from non JavaFX threads.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/4916/files#diff-7653fe88b27c966f6dd2f862c436fee5e5581ab2648c08888ac95afd7cd5c471">core/src/main/java/bisq/core/btc/setup/WalletsSetup.java</a>
    (8)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/4916.patch'>https://github.com/bisq-network/bisq/pull/4916.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/4916.diff'>https://github.com/bisq-network/bisq/pull/4916.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4916">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQG5GIZG72CH52O6NTSTZVLPANCNFSM4USLGFNA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQO6EOELTM26YFVZKLSTZVLPA5CNFSM4USLGFNKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LKHWMGQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4916",
"url": "https://github.com/bisq-network/bisq/pull/4916",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>