<ul>
<li>
<p>Added optional memo parameter to the api's <code>sendbtc</code> and <code>withdrawfunds</code> commands.</p>
</li>
<li>
<p>Removed the <code>@Nullable</code> annotation was removed because protobuf does not support null. The implementation will pass null if parameter string is empty.</p>
</li>
<li>
<p>Visibility in two <code>CoreWalletService</code> wallet check methods were changed from private to pkg protected so the <code>CoreTradeService</code> could use them.</p>
</li>
<li>
<p>Adjusted affected tests. (Asserting the memo field was set on a transaction cannot be checked from <code>apitest</code> yet.)</p>
</li>
</ul>
<p>This is the 5th in a chain of PRs beginning with <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="756290293" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4884" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4884/hovercard" href="https://github.com/bisq-network/bisq/pull/4884">#4884</a>.<br>
PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="759883796" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4922" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4922/hovercard" href="https://github.com/bisq-network/bisq/pull/4922">#4922</a> should be reviewed before this one.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/4925'>https://github.com/bisq-network/bisq/pull/4925</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Refactor BtcWalletService to let api override fee rates</li>
<li>Merge branch 'master' into 02-refactor-completePreparedSendBsqTx</li>
<li>Add optional txFeeRate parameter to api sendbsq</li>
<li>Merge branch 'master' into 03-add-txFeeRate-param</li>
<li>Add new api method 'sendbtc' and test</li>
<li>Merge branch 'master' into 04-add-sendbtc-impl</li>
<li>Support tx memo field for btc withdrawals from api</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-44d1f675626693524cb12d599245a09b4318db027c2dabd23e10cd98ceb7fd28">apitest/src/test/java/bisq/apitest/method/MethodTest.java</a>
(67)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-c41ca392649706fed19bf13247aeab25d0aa4ec109c93691aa2e7839b0fea70d">apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-0a94ee487ea9d0b7b440b8688f6e9df897fd089fc84ead5f6cc9ca9453ad3b21">apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-6c369bf146b35b7c634ad739e48b95ec315679f63e9e557821c83419002758cc">apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-bd2bdbad386129ffb2e5a7c90f46a406f67c2b55316771577c89104292251237">apitest/src/test/java/bisq/apitest/method/wallet/BtcWalletTest.java</a>
(37)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-b4de23450b7705336f77c570c064b19161e2b637d3d77b7ebe2deec2ca9911bc">apitest/src/test/java/bisq/apitest/scenario/WalletTest.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-afc5db1c8acb08dec253ee87a3e0e677c932d6826a2ab4c31ba816a4dcfb1386">cli/src/main/java/bisq/cli/CliMain.java</a>
(102)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-fb5876d3b212d239a14d78529ac498b30a2dbb8e3f184ba9bd711a5d4901fb62">core/src/main/java/bisq/core/api/CoreApi.java</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-7ab5c96db69bcc7ca05627ada97fd93b423f7df355641a7cd371d31f2039baf9">core/src/main/java/bisq/core/api/CoreTradesService.java</a>
(25)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-f1df4fd99db45d9b91ec2a59f443619324e243cb5738a597ef8008b67cc97d9a">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>
(106)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-0f421b3d29f6cd7b91f537f92b5c52c0144bf059d83ad9e7a897d416a88f68f8">core/src/main/java/bisq/core/api/model/TxInfo.java</a>
(84)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-51ad8d296d65d6b3ce8dc9791aa5a912f3ed622796fcd9853692711086c48972">core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-75820b5165905d1e3a47d5fe31e4b5dba017c6b25a322aad955ffa592a67b362">core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java</a>
(47)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-56c1ef7bad0acf4aaabd20d77fe9c3a1fcee2dd75665b605cb1d9217115ec0dd">core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-149b20e6e9412d3da47778e9e0fde8fb014864693abd9e036df4154e86bb08b2">core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-0999abe6a76f18c5be810b6c5436cea6d708c11d99ed316d0397c3ebbc6aa777">daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-2599dd16bc53cae95cd20c7466d22e1a79ae172db0526cd14f7839cee29ad9fe">daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java</a>
(87)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-129ab70d7a6a053bd296608a694f5ce120f764cb1c5ce4ec7d6a7d55a1efff92">desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4925/files#diff-dcb44a0045a5b02cde5bd2f45051b7d9293f87180111c7ea57f0d0eb85d0f393">proto/src/main/proto/grpc.proto</a>
(41)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/4925.patch'>https://github.com/bisq-network/bisq/pull/4925.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/4925.diff'>https://github.com/bisq-network/bisq/pull/4925.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4925">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWURO5F2YDYSRK6LBDST7JBPANCNFSM4UT7N2KA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWJMVI7THMGXLTS4MDST7JBPA5CNFSM4UT7N2KKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LKWHXMQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4925",
"url": "https://github.com/bisq-network/bisq/pull/4925",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>