<p>Send raw tx to mempool space explorer nodes.<br>
Use <a rel="nofollow" href="https://mempool.space/api">https://mempool.space/api</a></p>
<p>Posting the tx still does not work for unknown reasons...</p>
<p>Based on <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="765732233" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4942" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4942/hovercard" href="https://github.com/bisq-network/bisq/pull/4942">#4942</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/4943'>https://github.com/bisq-network/bisq/pull/4943</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Refactor: extract variable (no functional change)</li>
<li>Refactor: Move config of httpClient to static method (we will</li>
<li>Refactor: Move getConfiguredHttpClient to Util class and make it generic</li>
<li>Use Lombok setter and getters</li>
<li>Update toString method</li>
<li>Remove requestWithGETNoProxy methods from interface (not used outside)</li>
<li>Refactor: Extract method getSocks5Proxy</li>
<li>Refactor getSocks5Proxy method: Return early, make flow more clear</li>
<li>Rearrange: move method down</li>
<li>Add HttpMethod enum</li>
<li>Add baseUrl as param, extract variable</li>
<li>Improve logging</li>
<li>Rename httpclient (make it more distinct to Bisq Httpclient)</li>
<li>Add post method. Add doRequest method</li>
<li>Refactor: Rename 'requestWithGET' to 'get'</li>
<li>- Add hasPendingRequest() getter and block repeated requests</li>
<li>Check if we have a pending request and return if thats the case</li>
<li>Use dedicated HttpClient for fee requests</li>
<li>Fix incorrect checkArgument</li>
<li>Improve logs</li>
<li>Use @Singleton annotation instead of definition in module</li>
<li>Rename PriceNodeHttpClient to PriceHttpClient</li>
<li>Improve thread name</li>
<li>Improve log</li>
<li>Add TX_BROADCAST_SERVICES_CLEAR_NET and</li>
<li>Merge branch 'refactor-http-client' into add-tx-broadcast-to-mempool-explorer-api</li>
<li>Add MemPoolSpaceTxBroadcaster</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-0acc7d00f8368b0f79485d84162b2beb9487b061fd2d31aeb529e06d7c10d299">core/src/main/java/bisq/core/app/BisqSetup.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-f00209b3d1d74b20463771ed81b79f1a2b031aac78adbb5ce84bba01bbbc42e5">core/src/main/java/bisq/core/btc/BitcoinModule.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-ca999ccd160a616d7fd42ed8bb22d2603bc02c0520ec6751d35ca07cd51e5f98">core/src/main/java/bisq/core/btc/wallet/TxBroadcaster.java</a>
(7)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-2cd6a7121e45511aebab067b7d32579de8a55e9ecffa8af0aa0e7082a7dcb5a5">core/src/main/java/bisq/core/btc/wallet/http/MemPoolSpaceTxBroadcaster.java</a>
(129)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-29953a32b1409c280f07d0727f91abd5ec226a68b5a36dd19eb9396ef0aff90d">core/src/main/java/bisq/core/btc/wallet/http/TxBroadcastHttpClient.java</a>
(32)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-431a8b3544b872a62930176a27ea6e5ffde7691fccf876399eefade360ae95c4">core/src/main/java/bisq/core/notifications/MobileNotificationService.java</a>
(7)
</li>
<li>
<strong>R</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-f53952e8ed67dcad7df0a98c79ca8c159cb14ef0ff1401093847377eddf29f9c">core/src/main/java/bisq/core/provider/FeeHttpClient.java</a>
(6)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-2a26d81862c7c305b59224a6d0a377621f8a5b456ab94e6672db26c9d0827ee6">core/src/main/java/bisq/core/provider/PriceHttpClient.java</a>
(34)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-68cf287d0cc81007fa439a8a7d2542e9fe692846f851c41ff825281886eb0013">core/src/main/java/bisq/core/provider/fee/FeeProvider.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-4f98141725a189624c43d488db08c0ce904e07d35a35982d1e7127c1266b8f29">core/src/main/java/bisq/core/provider/fee/FeeRequest.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-04803da5fb51eabd94e0e0ca1ff8cf0cc7d39181abc242b1c3626b2c1b4546c3">core/src/main/java/bisq/core/provider/fee/FeeService.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-28316943939a2acc8c449f20b3a46754e69cebffd44ff96a7eec2d73a788f13f">core/src/main/java/bisq/core/provider/price/PriceFeedService.java</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-229df2770141fa8f2b0e5ac6c57ee7812d71952cae1986ee44db73d756c9432b">core/src/main/java/bisq/core/provider/price/PriceProvider.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-e29c56d124859f23f8f5816cebd12b8aed52f9627d55994184ac8abb9b369f6f">core/src/main/java/bisq/core/provider/price/PriceRequest.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-9253ed3a91037e15b46747a62fb1d08076eb63550fecb6985de075e7ae846694">core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofRequest.java</a>
(26)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-3117f0897492bb1e296445c33b6d902d7a030ac0b6c47072e33a7a7af4a67baf">core/src/main/java/bisq/core/user/Preferences.java</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-980efdcb1ceba8ab7e76964341a35d3b8b71f3f2aaae6aa8c6ac422a5763bd02">p2p/src/main/java/bisq/network/http/HttpClient.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-76645e227f693cb477540227ae3d7bc7d5f548dd88a561d999a5ab9b61553cae">p2p/src/main/java/bisq/network/http/HttpClientImpl.java</a>
(220)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-1fa6eff89299ccdf5ed2dac558c0edd89e153d2681c5a3571366e6326cd76794">p2p/src/main/java/bisq/network/http/HttpClientUtil.java</a>
(37)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/4943/files#diff-f81ed7fc223b8b9f4575d70ff297b89dcb10f10b0e377efef11f0577965bad97">p2p/src/main/java/bisq/network/http/HttpMethod.java</a>
(23)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/4943.patch'>https://github.com/bisq-network/bisq/pull/4943.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/4943.diff'>https://github.com/bisq-network/bisq/pull/4943.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4943">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQCIISOK63XSIQAI5TSUVN3ZANCNFSM4UZ5WIZQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXURBCJJE2IV2DS3FTSUVN3ZA5CNFSM4UZ5WIZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LNEFNDQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4943",
"url": "https://github.com/bisq-network/bisq/pull/4943",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>