<p></p>
<p><b>@wiz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4943#discussion_r542526378">core/src/main/java/bisq/core/btc/wallet/http/MemPoolSpaceTxBroadcaster.java</a>:</p>
<pre style='color:#555'>> @@ -115,8 +114,21 @@ public void onSuccess(String txId) {
             }
 
             public void onFailure(@NotNull Throwable throwable) {
-                log.warn("Broadcast of raw tx with txId {} to {} failed. Error={}",
-                        txIdToSend, url, throwable.toString());
+                Throwable cause = throwable.getCause();
+                if (cause instanceof HttpException) {
+                    int responseCode = ((HttpException) cause).getResponseCode();
+                    String message = cause.getMessage();
+                    if (responseCode == 400 && message.equals("sendrawtransaction RPC error: {\"code\":-27,\"message\":\"Transaction already in block chain\"}")) {
</pre>
<p>Instead of checking for that exact message, maybe just checking for a substring of <code>\"code\":-27</code> is better, since the exact string might change in future releases of Bitcoin Core RPC</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4943#pullrequestreview-551568014">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQMYM6KJGTKMQKFHVLSUY5BTANCNFSM4UZ5WIZQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUC3XUMSRX7NXK2YMTSUY5BTA5CNFSM4UZ5WIZ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEDQEFDQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4943#pullrequestreview-551568014",
"url": "https://github.com/bisq-network/bisq/pull/4943#pullrequestreview-551568014",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>