<p></p>
<p><b>@sqrrm</b> approved this pull request.</p>

<p>utACK on the changes</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4955#discussion_r543723703">core/src/main/java/bisq/core/locale/CurrencyUtil.java</a>:</p>
<pre style='color:#555'>> @@ -62,6 +62,14 @@ public static void setup() {
 
     private static String baseCurrencyCode = "BTC";
 
+    // Calls to isFiatCurrency and isCryptoCurrency are very frequent so we use a cache of the results.
+    // The main improvement was already achieved with using memoize for the source maps, but
+    // the caching still improves performance by about 20% for isCryptoCurrency and about 100%
</pre>
<p>100% improvement sounds wrong, 10%?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4955#pullrequestreview-552971217">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNULNRUFGVRRKAEZRDLSU7OFTANCNFSM4U32MLCA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNU7DCENUKFZAE23B2TSU7OFTA5CNFSM4U32MLCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOED22XUI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4955#pullrequestreview-552971217",
"url": "https://github.com/bisq-network/bisq/pull/4955#pullrequestreview-552971217",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>