<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/4937#discussion_r543747251">core/src/main/java/bisq/core/trade/Trade.java</a>:</p>
<pre style='color:#555'>> @@ -317,6 +317,10 @@ public boolean isArbitrated() {
@Getter
@Setter
private String payoutTxId;
+ @Nullable
+ @Getter
+ @Setter
+ private String withdrawalTxId;
</pre>
<p>I did not think this would make much sense to anyone until they've seen the next <a href="https://github.com/bisq-network/bisq/pull/4948" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4948/hovercard">PR</a>, and I explain my reason a bit more/better.</p>
<p>Here is Bob's <code>gettrade</code> CLI output after withdrawing funds to an external wallet:</p>
<pre><code>ID My Role Price in USD for 1 BTC Amount(BTC) Tx Fee(BTC) Taker Fee(BTC) Deposit Published Deposit Confirmed Fiat Sent Fiat Received Payout Published Withdrawn Withdrawal TX ID
5006844 BTC buyer as taker 19,410.6419 0.12500000 0.00012932 0.00037500 YES YES YES YES YES YES 0128e08406542a15ecc27234afa9ca9f4112f74d105459d18b4cfde93028291b
</code></pre>
<p>If <code>Withdrawn</code> = NO, the <code>Withdrawal TX ID</code> column would not appear in the console output.</p>
<p>Here is Bob's <code>gettransaction</code> CLI output:</p>
<pre><code>Tx ID Is Confirmed Tx Inputs (BTC) Tx Outputs (BTC) Tx Fee (BTC) Tx Size (Bytes) Memo
0128e08406542a15ecc27234afa9ca9f4112f74d105459d18b4cfde93028291b YES 0.14375000 0.14368229 0.00006771 193 Bob's trade withdrawal
</code></pre>
<p>Likewise, if there is no memo, the <code>Memo</code> column is not displayed.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4937#discussion_r543747251">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWMRLWBVTQFN6H5GTLSU7SP7ANCNFSM4UYIG6IA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNR7MEY5LMQRSUP4QWLSU7SP7A5CNFSM4UYIG6IKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOED3K62I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4937#discussion_r543747251",
"url": "https://github.com/bisq-network/bisq/pull/4937#discussion_r543747251",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>