<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4950#discussion_r544295572">core/src/main/java/bisq/core/offer/OpenOfferManager.java</a>:</p>
<pre style='color:#555'>>          }
+
+        OpenOffer openOffer = list.remove(0);
+        if (!openOffers.contains(openOffer) || openOffer.isDeactivated()) {
</pre>
<p>No it is correct, we call our recursive method with the list where we have removed that offer. But the following lines neede to be in a else branch.<br>
I made a PR where I invert the if check and add a comment.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4950#discussion_r544295572">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSI4E2IL5HXLJ6DPSLSVCYQFANCNFSM4U3UOSDQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNU46WVAUKR33OPYLOLSVCYQFA5CNFSM4U3UOSD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEEAIGOI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4950#discussion_r544295572",
"url": "https://github.com/bisq-network/bisq/pull/4950#discussion_r544295572",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>