<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4953#discussion_r544725593">core/src/main/java/bisq/core/account/sign/SignedWitnessService.java</a>:</p>
<pre style='color:#555'>>      private final Map<P2PDataStorage.ByteArray, SignedWitness> signedWitnessMap = new HashMap<>();
+
+    // The getSignedWitnessSet is called very often and is a bit expensive. We cache the result in that map but we
+    // remove the cache entry if we get a matching SignedWitness added to the signedWitnessMap.
+    private final Map<P2PDataStorage.ByteArray, Set<SignedWitness>> getSignedWitnessSetCache = new ConcurrentHashMap<>();
</pre>
<p>Agree...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4953#discussion_r544725593">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV33ZRORDVK2MOVTGDSVFHSXANCNFSM4U32MFNA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWW4MIT7GF3MOCIXRLSVFHSXA5CNFSM4U32MFNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEEEF6MI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4953#discussion_r544725593",
"url": "https://github.com/bisq-network/bisq/pull/4953#discussion_r544725593",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>