<p></p>
<p>Hi, this is my 2nd PR, just a little less trivial than my first one. I picked it up mainly to learn a bit more about the internals.</p>
<p>As I was making changes I realized that this rabbit hole goes deeper than I originally anticipated. On one hand, translating <strong>all</strong> <code>checkArgument</code> messages could introduce dozens and dozens of new strings, lots of extra work for the translators. On the other hand, most messages seem to be practically impossible to reach by regular users.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4978#issuecomment-748536817">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXMXFUHUSAXZX4BFRLSVUWCBANCNFSM4VCTVGJA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUMZU3DCD4LDYUFNCDSVUWCBA5CNFSM4VCTVGJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFSO4H4I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4978#issuecomment-748536817",
"url": "https://github.com/bisq-network/bisq/pull/4978#issuecomment-748536817",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>