<p></p>
<p><b>@sqrrm</b> requested changes on this pull request.</p>

<p>Functionality now looks right. Just some comments on naming.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4966#discussion_r547925642">daemon/src/main/java/bisq/daemon/grpc/interceptor/GrpcCallRateMeter.java</a>:</p>
<pre style='color:#555'>>  
-    @Nullable
-    private Timer timer;
+    private transient final ArrayDeque<Long> callTimestamps;
 
     public GrpcCallRateMeter(int allowedCallsPerTimeUnit, TimeUnit timeUnit) {
</pre>
<p><code>allowedCallsPerTimeUnit</code> is a bit misleading as it's really allowedCallsPerTimeWindow.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4966#discussion_r547926948">daemon/src/main/java/bisq/daemon/grpc/interceptor/GrpcCallRateMeter.java</a>:</p>
<pre style='color:#555'>>      }
 
-    public void incrementCallsCount() {
-        callsCount++;
+    public boolean isAllowed() {
</pre>
<p><code>isAllowed()</code> indicates it's just checking if something is allowed, this method i changing the state of the class. I would prefer something <code>call(successCallback, failCallback)</code> or <code>checkAndIncrement()</code></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4966#pullrequestreview-557827065">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV7GU4HASTW3ASQRRTSWHM57ANCNFSM4U772BAQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXHS5XQEEC5IZ4Z6ETSWHM57A5CNFSM4U772BA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEE74H6I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4966#pullrequestreview-557827065",
"url": "https://github.com/bisq-network/bisq/pull/4966#pullrequestreview-557827065",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>