<p>Implements <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="774124977" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4998" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4998/hovercard" href="https://github.com/bisq-network/bisq/issues/4998">#4998</a></p>
<p>Based on <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="773325094" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4993" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4993/hovercard" href="https://github.com/bisq-network/bisq/pull/4993">#4993</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5001'>https://github.com/bisq-network/bisq/pull/5001</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add percentage price to open offer view</li>
<li>Merge branch 'add-percentage-price-to-open-offer-view' into deactivate-open-offer-if-trigger-price-is-reached</li>
<li>Refactor InfoInputTextField</li>
<li>Apply formatting (no code change)</li>
<li>Add getRegularIconButton method</li>
<li>Add triggerPrice</li>
<li>Add PriceEventHandler</li>
<li>Set priceTypeToggleButton invisible once we move to funds section</li>
<li>Add trigger price field to create offer view</li>
<li>Make rows smaller</li>
<li>Add trigger price to OpenOffersView</li>
<li>Add trigger icon column</li>
<li>Add triggerPrice to csv</li>
<li>Add dontShowAgain to edit offer success popup</li>
<li>Rename wrong params</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-e66126b732dbd45cde04307641186caa214407bc74403812b10d3ebf18d2aecc">core/src/main/java/bisq/core/api/CoreOffersService.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-37c3b47b826f623fefe33260bc604f9fd907cc45d7a3c1d8d3f6f71de34f8c7f">core/src/main/java/bisq/core/app/DomainInitialisation.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-c953cf8693d7e14d2c3bf589fb871e4efc56c3db5f3074a48be8e9e9ac0f46d8">core/src/main/java/bisq/core/offer/OpenOffer.java</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-5e151a76cef2e8ffea07c4d456f312d5eb446f0fa1b813c467b677a9323164c6">core/src/main/java/bisq/core/offer/OpenOfferManager.java</a>
(8)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-6b7ed5da702d60285e015b3853cfa5d7049278fee5f06331cbfafbfbea7336f3">core/src/main/java/bisq/core/offer/TriggerPriceService.java</a>
(163)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-bd3cff2cc0fb251b82855b72911782bc1a6f2025f3da11f67cbae4f2d03c79a9">core/src/main/java/bisq/core/util/FormattingUtils.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-a6cc570e0f56a36136791beae8f497706216230467708be9343344cd953e5f08">core/src/main/resources/i18n/displayStrings.properties</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-bdcbd615f744936390c6daa13392dbc15233eac01531561e374f3e1a49890610">desktop/src/main/java/bisq/desktop/components/InfoInputTextField.java</a>
(126)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-5a5cd35dd693391c5a04dcc9ddf4d845762feafe9ed6172a7db160267d4bc2a4">desktop/src/main/java/bisq/desktop/main/PriceUtil.java</a>
(233)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-3850cdbbd637e3109806abee20cc2a9df5aa166a34b4af9a3078b81fa9dbacc6">desktop/src/main/java/bisq/desktop/main/account/content/notifications/MobileNotificationsView.java</a>
(33)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-af0f8f047cdd0690e2e65f21dccc5d3c7b112706656de24054412a61bea76ba5">desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-2d5247142b5c175cbd5adb2a063590022c401ffc0e0907321d6439e5bee69358">desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-4c9c687c0cf15c3fb5a759c6dbcb1ff6ba738a8bb372acfca0aa3d6bd64af8c9">desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-c07a4a25261a735296715e03648489d434fb39f93d11500ed770a58f21a8623e">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-3cf8bddee5a7364f6e0018392f074e94107ee04a145a51dec551b6b7145002f6">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>
(35)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-a110b4dbf593eb67e3a80e59506f58cd95ddbf8fe983bf3d967d8bbe2c8471fe">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java</a>
(109)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-6be5a2a3e9efad426d4520445826d641b9e78a901f8120af6c528cced19a0587">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java</a>
(96)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-292bc83a319461780bfee98968ea0598209a457183cfe15ae7f781071a0cc0fc">desktop/src/main/java/bisq/desktop/main/offer/OfferViewUtil.java</a>
(36)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-f7a4fc19540dc68f41d27e9c6e7908c737a95e8e544b1e4f8f4d280d2267ee2f">desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java</a>
(98)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-e91ddc497f0b94a9a80cc234cbdcedaf05e8f40e6e1d5fc7e9c9794f97063495">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-464b973414368d42f102b402b31160515781076ccee9f6fcd7f940b1929b9c81">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-574ce6bfa753de6de705ba360ded021a7a94dcc406ad740c009483f3a2effae7">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-9db2e8d962ffc7e9e66916eede60d8704c29bae66e0a1f1b6a86b0d22dc94cc3">desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-41b34a44d2df26644ec2e93e7c7211540603530d5d8649b0545ec4963b5315d5">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-e9676c9703f0234474175ef525059994983affdd4a511a01aca61de8a00f0546">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferView.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-ca6bbf820403f46339905b3e92bbea2ce13c25123540da103d578ccd6b3859e6">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-e73cb0ebc58d5b770f8a05a70a58b5eedcd897fa8f9bdc1d09a528433d77f4e7">desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesView.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-66ec3b0ba7969cb934d94ca481d1272fca1b515fd07ca46ead84f62e9bfe573e">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersDataModel.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-cb8213d486d1fb8be10a33e5aa69775dc38c3dbc2ff1ddffab5baebade8e3063">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersView.fxml</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-f38dd85004debdfdecc0b0bbc3d434ac2e62ff6df69d3176a848471b7a4edd42">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersView.java</a>
(141)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-b3b3909a29cf42d5b28144a07d1f517617db098c4c59caa24a964fcf8f9124f1">desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java</a>
(46)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-49b4e5ed6d34308027f6c7a15ca6de2b2ef07441aa7455ee185d24dbe7817ba0">desktop/src/main/java/bisq/desktop/util/FormBuilder.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5001/files#diff-51dcd1d852312df65738ff2bd493fdb0f187f50fb7d7324158c8b57fc1de7da7">proto/src/main/proto/pb.proto</a>
(1)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5001.patch'>https://github.com/bisq-network/bisq/pull/5001.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5001.diff'>https://github.com/bisq-network/bisq/pull/5001.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5001">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNU5Q6ZW6NV3BI5CVTLSWQPXRANCNFSM4VI22RVA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUEQQTIIEAOYNGWQOTSWQPXRA5CNFSM4VI22RVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LRL75TA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5001",
"url": "https://github.com/bisq-network/bisq/pull/5001",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>