<p></p>
<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4242#discussion_r549393685">desktop/package/package.gradle</a>:</p>
<pre style='color:#555'>> @@ -366,6 +366,57 @@ task packageInstallers {
                         " -vvvv" +
                         " --deep" +
                         " '${binariesFolderPath}/Bisq-${appVersion}.dmg'")
+
+                // macOS step 6: Upload for notarization
+                // See https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/customizing_the_notarization_workflow#3087734
+                String envVariableAcUsername = "$System.env.BISQ_PACKAGE_NOTARIZATION_AC_USERNAME"
+                String envVariableAscProvider = "$System.env.BISQ_PACKAGE_NOTARIZATION_ASC_PROVIDER"
+                def uploadForNotarizationOutput = executeCmd("xcrun altool --notarize-app" +
+                        " --primary-bundle-id 'network.bisq.CAT'" +
</pre>
<p>We should envize the <code>primary-bundle-id</code> argument as well, as it has to be unique for each developer (CAT -> Christoph ATteneder) who wants to publish a binary.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4242#pullrequestreview-559197893">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQBMIA5EOESESYYBWLSXCSARANCNFSM4M3JTONQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNT4FIBHGSA4KPFOFMTSXCSARA5CNFSM4M3JTON2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEFKK5RI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4242#pullrequestreview-559197893",
"url": "https://github.com/bisq-network/bisq/pull/4242#pullrequestreview-559197893",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>