<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5031'>https://github.com/bisq-network/bisq/pull/5031</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>We need to use the getMapOfAllData method for HistoricalDataStoreServices</li>
  <li>Use concrete dataStorageServices instead</li>
  <li>Log error (and throw exception if in devMode) if</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5031/files#diff-302170e4ff5d1335d189d96fcf2a0bedf298680d09df0a7aa16b68c8737ec5b2">core/src/main/java/bisq/core/account/sign/SignedWitnessService.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5031/files#diff-0acc7d00f8368b0f79485d84162b2beb9487b061fd2d31aeb529e06d7c10d299">core/src/main/java/bisq/core/app/BisqSetup.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5031/files#diff-b5696f2f5bb5ed4e1038719ef94bb48044122fd4eb09b0e937dcbf26eb578b6b">core/src/main/java/bisq/core/dao/governance/proposal/ProposalService.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5031/files#diff-89fda5dcb5d6f1b3d420717a41dfe4c6012de9c0904bf9d56d7cd086c516bd51">desktop/src/main/java/bisq/desktop/main/market/MarketView.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5031/files#diff-45fc34501c30dffd0b312454da94f2dd0c9df7b8135a4a5019606372c82c3959">p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5031/files#diff-2de457dc711428ac850d58efa397058a668c8935eac740a5ca596d70c3bd105a">p2p/src/main/java/bisq/network/p2p/storage/persistence/AppendOnlyDataStoreService.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5031/files#diff-6476309e3814cd08f9e340b79e48c1c2603a82d6ea4be4f74d977a514e6f7c1b">p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java</a>
    (11)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5031.patch'>https://github.com/bisq-network/bisq/pull/5031.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5031.diff'>https://github.com/bisq-network/bisq/pull/5031.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5031">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV4FIOCBX7JLHZQVXLSXPJ6TANCNFSM4VO5LSGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRQUZA3FTUMCY26XFDSXPJ6TA5CNFSM4VO5LSG2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LSLVWOA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5031",
"url": "https://github.com/bisq-network/bisq/pull/5031",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>