<p></p>
<p><b>@chimp1984</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5038#discussion_r551068832">core/src/main/java/bisq/core/filter/Filter.java</a>:</p>
<pre style='color:#555'>> @@ -91,6 +95,11 @@
     // added at v1.3.8
     private final boolean disableAutoConf;
 
+    // added at v1.5.5
+    // In contrast to bannedNodeAddress those addresses cannot access the network but are rejected immediately.
+    // Should be only used in case of dos attacks
+    private final Set<String> nodeAddressesBannedFromNetwork;
</pre>
<p>I think <code>nodeAddressesBannedFromNetwork</code> is pretty clear (and long ;-)) no? The <code>bannedNodeAddress</code> is not great but renaming it would require a rename if the protobuf field as well to avoid that those fields get out of sync and was not sure if thats worth it. Also not clear for a good alternative name.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5038#discussion_r551068832">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXK4MSWOZSFTSVNBT3SYD455ANCNFSM4VQRSSNA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQN3HLTKQ4CMQ4LCNTSYD455A5CNFSM4VQRSSNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEFWB5LA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5038#discussion_r551068832",
"url": "https://github.com/bisq-network/bisq/pull/5038#discussion_r551068832",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>