<p></p>
<p>After manually merging my <code>add-getmyoffers-api-method</code> branch's changes (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="778481098" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5056" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5056/hovercard" href="https://github.com/bisq-network/bisq/pull/5056">#5056</a>) into a clone of <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a> 's PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="778269219" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5053" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5053/hovercard" href="https://github.com/bisq-network/bisq/pull/5053">#5053</a>, I find that <code>offerFilter.canTakeOffer</code> is working as expected, at least in the core api.</p>
<p>I don't know how you want to proceed, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a>, but I would do the following:</p>
<ol>
<li>Back out all changes made in core.api for PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="778269219" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5053" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5053/hovercard" href="https://github.com/bisq-network/bisq/pull/5053">#5053</a> (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a>)</li>
<li>Review/Merge PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="778481098" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5056" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5056/hovercard" href="https://github.com/bisq-network/bisq/pull/5056">#5056</a> (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ghubstan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ghubstan">@ghubstan</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/sqrrm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a>)</li>
<li>Review/Merge PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="778269219" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5053" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5053/hovercard" href="https://github.com/bisq-network/bisq/pull/5053">#5053</a> (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/sqrrm/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a>)</li>
<li>Create a new PR to apply the filtering in core api's offers service (<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ghubstan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ghubstan">@ghubstan</a>)</li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5053#issuecomment-754665020">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNU5M42OZQ45NSB2U43SYMOBXANCNFSM4VTLWMTA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWMONAT63LY5VPFQ5TSYMOBXA5CNFSM4VTLWMTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFT5UMPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5053#issuecomment-754665020",
"url": "https://github.com/bisq-network/bisq/pull/5053#issuecomment-754665020",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>