<ul>
<li>
<p>Injected <code>OfferFilter</code> into <code>CoreOffersService</code> and <code>CoreTradesService</code>.<br>
The filter constrains <code>getoffer(s)</code> results to offers an api user can take, as the first part of ongoing protection tools / api integration.</p>
</li>
<li>
<p>Created a new <code>CoreContext</code> singleton.<br>
Initially, lets <code>Core*Services</code> know if the user is using the api -- <code>isApiUser=true</code> if the current thread's name is "BisqDaemonMain", or the name contains "grpc".  We cannot check <code>BisqDaemonMain.class.getSimpleName()</code> because <code>:core</code> cannot have a circular dependency on <code>:daemon</code>, but there is probably a better way to do this than depending on the thread name set in <code>BisqDaemonMain#configUserThread()</code>.  We do this anticipating future <code>:desktop</code> dependencies on the core api, and we don't pass hardcoded <code>isApiUser=true</code> params to lower level domain objects.</p>
</li>
<li>
<p>Added <code>@Singleton</code> annotation to all Core*Service classes.</p>
</li>
</ul>
<p>Related to <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="778269219" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5053" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5053/hovercard" href="https://github.com/bisq-network/bisq/pull/5053">#5053</a>.</p>
<p>PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="782149074" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5063" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5063/hovercard" href="https://github.com/bisq-network/bisq/pull/5063">#5063</a> should be reviewed and merged before this one.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5065'>https://github.com/bisq-network/bisq/pull/5065</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix two CLI option parsing bugs</li>
  <li>Add @Singleton annotation</li>
  <li>Integrate new protection tools into api's offer & trade services</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-afc5db1c8acb08dec253ee87a3e0e677c932d6826a2ab4c31ba816a4dcfb1386">cli/src/main/java/bisq/cli/CliMain.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-bc03e9b04d52b37f48d4f56aa608b4a50a2085dff40f9fc738d910ea5a72d599">cli/src/main/java/bisq/cli/CurrencyFormat.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-7800f1fd826976e3ed46ad7bdc0d0f93ae96021a49bfba65a53cd1b964a99ae1">cli/src/main/java/bisq/cli/NegativeNumberOptions.java</a>
    (22)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-e32480b8ab5765deb4b2cf89feec81a95f7ebd485ccb4f31575e5f7d46144350">core/src/main/java/bisq/core/api/CoreContext.java</a>
    (39)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-1fdf1185fccb8362ea36b94f59b8f569ad943594fa5d8d3a290186e23f733ddf">core/src/main/java/bisq/core/api/CoreDisputeAgentsService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-e66126b732dbd45cde04307641186caa214407bc74403812b10d3ebf18d2aecc">core/src/main/java/bisq/core/api/CoreOffersService.java</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-161be9419f5c0abf3098d8ac7d8b096a321bb76f0c26b5be11cc183958209368">core/src/main/java/bisq/core/api/CorePaymentAccountsService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-e5a0c31f957d7a443b525593a673a4f5c433d5a0aaa549a49979cfaac241666a">core/src/main/java/bisq/core/api/CorePriceService.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-7ab5c96db69bcc7ca05627ada97fd93b423f7df355641a7cd371d31f2039baf9">core/src/main/java/bisq/core/api/CoreTradesService.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5065/files#diff-f1df4fd99db45d9b91ec2a59f443619324e243cb5738a597ef8008b67cc97d9a">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5065.patch'>https://github.com/bisq-network/bisq/pull/5065.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5065.diff'>https://github.com/bisq-network/bisq/pull/5065.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5065">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWXNPH4CGONYH5HLADSY4YSXANCNFSM4V2VWVBQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVNF3A3AN2FQ77DS5LSY4YSXA5CNFSM4V2VWVB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LVAHBRQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5065",
"url": "https://github.com/bisq-network/bisq/pull/5065",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>